Skip to content

Commit

Permalink
Address cspell issues for Synapse (#25689)
Browse files Browse the repository at this point in the history
* address cspell issues for Synapse

* rename nbformat

* nits

* fix spelling issues

* fix
  • Loading branch information
annelo-msft authored Dec 13, 2021
1 parent ac7e23a commit 0f869ce
Show file tree
Hide file tree
Showing 7 changed files with 70 additions and 23 deletions.
30 changes: 29 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"sdk/objectanchors/*/api/*.cs",
"sdk/purview/*/api/*.cs",
"sdk/remoterendering/*/api/*.cs",
"sdk/synapse/*/api/*.cs",
"sdk/videoanalyzer/*/api/*.cs"
],
// cspell is not case sensitive
Expand Down Expand Up @@ -235,6 +234,35 @@
"Undelete"
]
},
{
"filename": "**/sdk/synapse/**/*.cs",
"words": [
"adla",
"adls",
"byoa",
"distcp",
"eloqua",
"exfiltration",
"fqdns",
"hana",
"hcatalog",
"hdfs",
"informix",
"magento",
"netezza",
"oozie",
"responsys",
"sasl",
"ssis",
"ssisdb",
"sybase",
"sybase",
"teradata",
"usql",
"vertica",
"xero"
]
},
{
"filename": "**/sdk/synapse/**/*.md",
"words": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4516,15 +4516,15 @@ public NetezzaTableDataset(Azure.Analytics.Synapse.Artifacts.Models.LinkedServic
}
public partial class Notebook
{
public Notebook(Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata metadata, int nbformat, int nbformatMinor, System.Collections.Generic.IEnumerable<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> cells) { }
public Notebook(Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata metadata, int notebookFormat, int notebookFormatMinor, System.Collections.Generic.IEnumerable<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> cells) { }
public System.Collections.Generic.IDictionary<string, object> AdditionalProperties { get { throw null; } }
public Azure.Analytics.Synapse.Artifacts.Models.BigDataPoolReference BigDataPool { get { throw null; } set { } }
public System.Collections.Generic.IList<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> Cells { get { throw null; } }
public string Description { get { throw null; } set { } }
public Azure.Analytics.Synapse.Artifacts.Models.NotebookFolder Folder { get { throw null; } set { } }
public Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata Metadata { get { throw null; } set { } }
public int Nbformat { get { throw null; } set { } }
public int NbformatMinor { get { throw null; } set { } }
public int NotebookFormat { get { throw null; } set { } }
public int NotebookFormatMinor { get { throw null; } set { } }
public Azure.Analytics.Synapse.Artifacts.Models.NotebookSessionProperties SessionProperties { get { throw null; } set { } }
}
public partial class NotebookCell
Expand Down Expand Up @@ -7132,7 +7132,7 @@ internal TriggerRunsQueryResponse() { }
private readonly int _dummyPrimitive;
public TriggerRunStatus(string value) { throw null; }
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Failed { get { throw null; } }
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Inprogress { get { throw null; } }
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus InProgress { get { throw null; } }
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Succeeded { get { throw null; } }
public bool Equals(Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus other) { throw null; }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/autorest.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,22 @@ directive:
}
}
```
### Fix spelling issues
``` yaml
directive:
from: swagger-document
where: $.definitions.Notebook.properties
transform: >
$.nbformat['x-ms-client-name'] = 'NotebookFormat';
$.nbformat_minor['x-ms-client-name'] = 'NotebookFormatMinor';
```
``` yaml
directive:
from: swagger-document
where: $.definitions.TriggerRun.properties
transform: >
$.status["x-ms-enum"].values = [{value: "Succeeded", name: "Succeeded" },{value: "Failed", name: "Failed" },{value: "Inprogress", name: "InProgress" }];
```
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public static async ValueTask<NotebookResource> CreateResource (NotebookClient c

Notebook notebook = new Notebook (
new NotebookMetadata { LanguageInfo = new NotebookLanguageInfo(name: "Python") },
nbformat: 4,
nbformatMinor: 2,
notebookFormat: 4,
notebookFormatMinor: 2,
new List<NotebookCell>()
);
NotebookCreateOrUpdateNotebookOperation createOperation = await client.StartCreateOrUpdateNotebookAsync(name, new NotebookResource(name, notebook));
Expand Down

0 comments on commit 0f869ce

Please sign in to comment.