Remove the suppression for namespace in mgmt sdks (#21534)

* remove no warn AZC0001 * remove the namespace warn suppression from mgmt plane sdks * remove old todo
Azure · Jun 2, 2021 · 289bb6b · 289bb6b
1 parent 5fc9126
commit 289bb6b
Show file tree

Hide file tree

Showing 16 changed files with 13 additions and 25 deletions.
diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
@@ -132,7 +132,7 @@
   -->
   <ItemGroup>
     <PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20210601.1" PrivateAssets="All" />
-    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210322.2" PrivateAssets="All" />
+    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210601.1" PrivateAssets="All" />
     <PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
     <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
     <PackageReference Update="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.20467.1" PrivateAssets="All" />

diff --git a/eng/templates/Azure.ResourceManager.Template/src/Azure.ResourceManager.Template.csproj b/eng/templates/Azure.ResourceManager.Template/src/Azure.ResourceManager.Template.csproj
@@ -5,9 +5,4 @@
     <Description>Azure Resource Manager client SDK for Azure resource provider ProviderFullName</Description>
     <PackageTags>azure;management;arm;resource manager;ProviderNameLowercase</PackageTags>
   </PropertyGroup>
-
-  <PropertyGroup>
-    <!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
-    <NoWarn>$(NoWarn);AZC0001</NoWarn>
-  </PropertyGroup>
 </Project>
diff --git a/.../Azure.ResourceManager.AppConfiguration/src/Azure.ResourceManager.AppConfiguration.csproj b/.../Azure.ResourceManager.AppConfiguration/src/Azure.ResourceManager.AppConfiguration.csproj
@@ -7,7 +7,7 @@
       This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
     </Description>
     <PackageTags>azure;management;appconfiguration</PackageTags>
-    <NoWarn>$(NoWarn);AZC0001;AZC0008;</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008;</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/...cation/Azure.ResourceManager.Communication/src/Azure.ResourceManager.Communication.csproj b/...cation/Azure.ResourceManager.Communication/src/Azure.ResourceManager.Communication.csproj
@@ -9,10 +9,6 @@
       For this release, see notes - https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/communication/Azure.ResourceManager.Communication/README.md and https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/communication/Azure.ResourceManager.Communication/CHANGELOG.md.
     </Description>
     <PackageTags>azure;management;communication</PackageTags>
-    <!--
-    AZC0001 - Azure.ResourceManager.Communication namespace needs to be registered in the analyzer
-    -->
-    <NoWarn>$(NoWarn);AZC0001</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj b/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj
@@ -12,7 +12,7 @@
 
   <PropertyGroup>
     <!-- TODO: Temp workaround. Should be fixed prior to release  -->
-    <NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj b/sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj
@@ -8,7 +8,7 @@
 
   <PropertyGroup>
     <!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
-    <NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/dns/Azure.ResourceManager.Dns/src/Azure.ResourceManager.Dns.csproj b/sdk/dns/Azure.ResourceManager.Dns/src/Azure.ResourceManager.Dns.csproj
@@ -17,7 +17,7 @@
   </PropertyGroup>
   <PropertyGroup>
     <!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
-    <NoWarn>$(NoWarn);AZC0001;CS0618</NoWarn>
+    <NoWarn>$(NoWarn);CS0618</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/eventhub/Azure.ResourceManager.EventHubs/src/Azure.ResourceManager.EventHubs.csproj b/sdk/eventhub/Azure.ResourceManager.EventHubs/src/Azure.ResourceManager.EventHubs.csproj
@@ -7,7 +7,7 @@
       This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
     </Description>
     <PackageTags>azure;management;eventhub</PackageTags>
-    <NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/insights/Azure.ResourceManager.Insights/src/Azure.ResourceManager.Insights.csproj b/sdk/insights/Azure.ResourceManager.Insights/src/Azure.ResourceManager.Insights.csproj
@@ -7,8 +7,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
-    <NoWarn>$(NoWarn);AZC0001</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/keyvault/Azure.ResourceManager.KeyVault/src/Azure.ResourceManager.KeyVault.csproj b/sdk/keyvault/Azure.ResourceManager.KeyVault/src/Azure.ResourceManager.KeyVault.csproj
@@ -8,7 +8,7 @@
     </Description>
     <PackageTags>azure;management;keyvault</PackageTags>
     <!-- TODO: Temp workaround. Should be fixed prio release  -->
-    <NoWarn>$(NoWarn);AZC0001;AZC0008;</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008;</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/...eManager.MachineLearningServices/src/Azure.ResourceManager.MachineLearningServices.csproj b/...eManager.MachineLearningServices/src/Azure.ResourceManager.MachineLearningServices.csproj
@@ -11,9 +11,8 @@
   </PropertyGroup>
 
     <PropertyGroup>
-    <!-- TODO: Temp workaround to avoid error for preapproved namespace groups. Should be fixed prior to release  -->
     <!-- Link to preapproved, registered namespaces: https://azure.github.io/azure-sdk/registered_namespaces.html  -->
-    <NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj b/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj
@@ -12,7 +12,7 @@
 
   <PropertyGroup>
     <!-- TODO: Temp workaround. Should be fixed prio release  -->
-    <NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/sdk/resourcemanager/Azure.ResourceManager.Core/src/Azure.ResourceManager.Core.csproj b/sdk/resourcemanager/Azure.ResourceManager.Core/src/Azure.ResourceManager.Core.csproj
@@ -8,7 +8,7 @@
       This is a beta preview vesion.  This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
     </Description>
     <PackageTags>azure;management;resource</PackageTags>
-    <NoWarn>$(NoWarn);AZC0008;AZC0001;AZC0107;CA2214;CA1036;CA1067;CA1065;SA1028</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008;AZC0107;CA2214;CA1036;CA1067;CA1065;SA1028</NoWarn>
     <IncludeGeneratorSharedCode>true</IncludeGeneratorSharedCode>
   </PropertyGroup>
 

diff --git a/sdk/resources/Azure.ResourceManager.Resources/src/Azure.ResourceManager.Resources.csproj b/sdk/resources/Azure.ResourceManager.Resources/src/Azure.ResourceManager.Resources.csproj
@@ -7,7 +7,7 @@
       This is a beta preview vesion.  This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
     </Description>
     <PackageTags>azure;management;resource</PackageTags>
-    <NoWarn>$(NoWarn);AZC0008;AZC0001</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj b/sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj
@@ -9,7 +9,7 @@
 
   <PropertyGroup>
     <!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
-    <NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>
 

diff --git a/sdk/storage/Azure.ResourceManager.Storage/src/Azure.ResourceManager.Storage.csproj b/sdk/storage/Azure.ResourceManager.Storage/src/Azure.ResourceManager.Storage.csproj
@@ -7,7 +7,7 @@
       This is a beta preview vesion.  This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
     </Description>
     <PackageTags>azure;management;storage</PackageTags>
-    <NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
+    <NoWarn>$(NoWarn);AZC0008</NoWarn>
     <ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
   </PropertyGroup>