Azure.Provisioning: Avoid excess nulls in BicepStringBuilder

Azure · Oct 21, 2024 · acbd6e3 · acbd6e3
1 parent 3fadc42
commit acbd6e3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/sdk/provisioning/Azure.Provisioning.Storage/tests/BasicStorageTests.cs b/sdk/provisioning/Azure.Provisioning.Storage/tests/BasicStorageTests.cs
@@ -270,11 +270,12 @@ await test.Define(
                 infra.Add(new ProvisioningOutput("blobs_endpoint", typeof(string)) { Value = storage.PrimaryEndpoints.Value!.BlobUri });
 
                 // Manually compute the public Azure endpoint
+                string? nothing = null;
                 BicepValue<string> computed =
                     new BicepStringBuilder()
                     .Append("https://")
                     .Append($"{storage.Name}")
-                    .Append(".blob.core.windows.net");
+                    .Append($".blob.core.windows.net{nothing}");
                 infra.Add(new ProvisioningOutput("computed_endpoint", typeof(string)) { Value = computed });
 
                 return infra;

diff --git a/sdk/provisioning/Azure.Provisioning/src/Expressions/BicepStringBuilder.cs b/sdk/provisioning/Azure.Provisioning/src/Expressions/BicepStringBuilder.cs
@@ -100,12 +100,13 @@ public void AppendFormatted<T>(T t)
             _expressions.Add(BicepSyntax.Var(v.BicepIdentifier));
             _isSecure = _isSecure || v.Value.IsSecure;
         }
-        else
+        else if (t is not null)
         {
-            _expressions.Add(
-                t is null ?
-                    BicepSyntax.Null() :
-                    BicepSyntax.Value(t.ToString() ?? ""));
+            string? s = t.ToString();
+            if (s is not null)
+            {
+                _expressions.Add(BicepSyntax.Value(s));
+            }
         }
     }