[Storage] OpenRead/Write test recordings are back. (#14963)

* Prepare Storage for release

* pr feedback.

* PR feedback.

* pr feedback.

* make open write work with using.

* move recordings to right place

* pr feedback.

* record open write tests.

sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs

@@ -924,7 +924,6 @@ public async Task DownloadEmptyBlobTest()
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync()
         {
             int size = Constants.KB;
@@ -947,7 +946,6 @@ public async Task OpenReadAsync()
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_BufferSize()
         {
             int size = Constants.KB;
@@ -1030,7 +1028,6 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_AccessConditions()
         {
             // Arrange
@@ -1107,7 +1104,6 @@ await TestHelper.CatchAsync<Exception>(
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_StrangeOffsetsTest()
         {
             // Arrange
@@ -1150,7 +1146,6 @@ public async Task OpenReadAsync_StrangeOffsetsTest()
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_Modified()
         {
             int size = Constants.KB;
@@ -1191,7 +1186,6 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_ModifiedAllowBlobModifications()
         {
             int size = Constants.KB;
@@ -1275,7 +1269,6 @@ await blobClient.UploadAsync(stream,
         }
 
         [Test]
-        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/13510
         public async Task OpenReadAsync_CopyReadStreamToAnotherStream()
         {
             // Arrange

sdk/storage/Azure.Storage.Blobs/tests/BlockBlobClientTests.cs

@@ -2425,7 +2425,6 @@ await TestHelper.AssertExpectedExceptionAsync<ArgumentException>(
         }
 
         [Test]
-        [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/13510")]
         public async Task OpenWriteAsync_ModifiedDuringWrite()
         {
             // Arrange
@@ -2438,7 +2437,7 @@ public async Task OpenWriteAsync_ModifiedDuringWrite()
             // Act
             Stream openWriteStream = await blob.OpenWriteAsync(overwrite: true);
 
-            string blockId = GenerateBlockId();
+            string blockId = ToBase64(GetNewBlockName());
             await blob.StageBlockAsync(blockId, stream);
             stream.Position = 0;
             await blob.CommitBlockListAsync(new List<string> { blockId });
@@ -2545,13 +2544,6 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
             }
         }
 
-        private static string GenerateBlockId()
-        {
-            Guid guid = Guid.NewGuid();
-            byte[] bytes = Encoding.UTF8.GetBytes(guid.ToString());
-            return Convert.ToBase64String(bytes);
-        }
-
         private RequestConditions BuildRequestConditions(AccessConditionParameters parameters)
             => new RequestConditions
             {