Azure.Search: Determine the correct approach for nested SearchErrors

[tg-msft]

The swagger includes nested errors as details and we should determine how we want to expose them.

[tg-msft]

https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/search/Azure.Search.Documents/src/Utilities/ClientDiagnostics.ExtractFailureContent.cs#L52

and

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchindex.json#L1377

[tg-msft]

The service is working these out now. We'll probably have to put this in additionalInfo but will circle back in a preview or two.

[Mohit-Chakraborty]

An example of an error that triggers this assert is from the test RegexSpecialCharsUnescapedThrows()-

{
"error":
{
  "code":"InvalidRequestParameter",
  "message":"Failed to parse query string at line 1, column 8. See https://aka.ms/azure-search-full-query for supported syntax.",
  "details":
    [
    {"code":"InvalidSearchSyntax",
     "message":"Failed to parse query string at line 1, column 8. See https://aka.ms/azure-search-full-query for supported syntax."
    }
    ]
}
}

[Mohit-Chakraborty]

This is also causing the same 8 test failures in Search weekly tests where the tests expects a particular exception to be thrown but the assert fires instead.
Here is a sample run.

[AlexGhiondea]

@Mohit-Chakraborty anything else left for us to do here?

[Mohit-Chakraborty]

I see there has been a reformatting of code and we have removed the custom code in favor of using the common impl from Azure.Core.
The assert calling out the problem does not exist in this version.

I thought we still need a way to agree on how to surface nested errors. I will follow-up on it.

[pallavit]

@ShivangiReja could you please check if there is anything left to be done here or can we close this issue?

[pallavit]

@ShivangiReja I believe we can close this issue as not planned. Please feel free to open if you feel otherwise. /cc: @tg-msft as FYI.