Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PatternAnalyzer and PatternTokenizer should accept an array of RegexFlags #10748

Closed
heaths opened this issue Mar 20, 2020 · 0 comments · Fixed by #11461
Closed

PatternAnalyzer and PatternTokenizer should accept an array of RegexFlags #10748

heaths opened this issue Mar 20, 2020 · 0 comments · Fixed by #11461
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] May

Comments

@heaths
Copy link
Member

heaths commented Mar 20, 2020

Because it's expected that multiple RegexFlags may be used in PatternAnalyzer and PatternTokenizer, the flags property should be an array of RegexFlags that de/serialize as a |-delimited string.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. Search labels Mar 20, 2020
@heaths heaths added this to the [2020] April milestone Mar 20, 2020
@heaths heaths self-assigned this Mar 20, 2020
@heaths heaths modified the milestones: [2020] April, [2020] May Apr 6, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Apr 8, 2020
Closed
26 tasks
@heaths heaths mentioned this issue Apr 20, 2020
Open
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Apr 20, 2020
@heaths
De/serialize |-delimited array of RegexFlags
c60d5b9 
Fixes Azure#10748
@heaths heaths mentioned this issue Apr 20, 2020
Merged
heaths added a commit that referenced this issue Apr 21, 2020
@heaths
De/serialize pipe-delimited array of RegexFlags (#11461)
2da59be 
* De/serialize |-delimited array of RegexFlags

Fixes #10748

* Declare related read-only collection properties

* Update public APIs

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] May
Development

Successfully merging a pull request may close this issue.

De/serialize pipe-delimited array of RegexFlags heaths/azure-sdk-for-net
1 participant
@heaths