Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add algorithms to EncryptionAlgorithm for Key Vault #14888

Closed
heaths opened this issue Sep 4, 2020 · 0 comments · Fixed by #16025
Closed

Add algorithms to EncryptionAlgorithm for Key Vault #14888

heaths opened this issue Sep 4, 2020 · 0 comments · Fixed by #16025
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2020] November

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020 •
edited
Loading

For Key Vault 7.2-preview, to EncryptionAlgorithm (in swagger, the KeyOperationsParameters model), add the following algorithms:

  • A128GCM
  • A192GCM
  • A256GCM
  • A128KW
  • A192KW
  • A256KW
  • A128CBC
  • A192CBC
  • A256CBC
  • A128CBCPAD
  • A192CBCPAD
  • A256CBCPAD

As many of these as possible should be supported locally without writing our own cryptography.

Also add the following properties:

  • Iv (model property: iv)
  • AdditionalAuthenticatedData (model property: aad)
  • Tag (model property: tag)

These will likely need to be in a new options type/parameter passed to Encrypt and Decrypt.

See the service version 7.1 -> 7.2-preview diff 🔒 for details.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@heaths heaths modified the milestones: [2020] October, [2020] November Oct 5, 2020
@heaths heaths mentioned this issue Oct 15, 2020
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Oct 16, 2020
@heaths
Add additional encryption algorithms to Keys
c67bde4 
Resolves Azure#14888
heaths added a commit that referenced this issue Oct 22, 2020
@heaths
Add support for AES encryption and key wrap algorithms (#16025)
5e79cd7 
* Add oct-HSM key type

Resolves #14887

* Add additional encryption algorithms to Keys

Resolves #14888

* Add AES-CBC and AES-GCM implementations/proxies

* Add AES support to AesCryptographyProvider

* Use factory methods for encrypt/decrypt options

* Update public API
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@heaths @annelo-msft
Add support for AES encryption and key wrap algorithms (Azure#16025)
ace60ea 
* Add oct-HSM key type

Resolves Azure#14887

* Add additional encryption algorithms to Keys

Resolves Azure#14888

* Add AES-CBC and AES-GCM implementations/proxies

* Add AES support to AesCryptographyProvider

* Use factory methods for encrypt/decrypt options

* Update public API
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Jun 18, 2021
@msyyc
CodeGen from PR 14888 in Azure/azure-rest-api-specs
c34c31d 
Operationsmanagement t1 del (Azure#14888)

* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* t1 del

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

Add support for AES encryption and key wrap algorithms heaths/azure-sdk-for-net
1 participant
@heaths