Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Security.KeyVault.Administration Readme issues #15306

Closed
Tianyun-G opened this issue Sep 22, 2020 · 5 comments
Closed

Azure.Security.KeyVault.Administration Readme issues #15306

Tianyun-G opened this issue Sep 22, 2020 · 5 comments
Assignees
@christothes
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Milestone
[2020] October

Comments

@Tianyun-G
Copy link
Contributor

Section link

image

Suggestion:
1.Update to https://cla.microsoft.com .

2.Update to [Microsoft Open Source Code of Conduct][code_of_conduct] .

3.Add [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/ .

4.Update to opencode@microsoft.com .

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 22, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 22, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Sep 22, 2020
@heaths heaths assigned christothes and unassigned heaths Sep 24, 2020
@heaths heaths removed the needs-team-triage Workflow: This issue needs the team to triage. label Sep 24, 2020
@heaths heaths added this to the [2020] October milestone Sep 24, 2020
@christothes christothes mentioned this issue Oct 6, 2020
Merged
ghost pushed a commit that referenced this issue Oct 6, 2020
@christothes
Add instructions to README for Managed HSM (#15720)
80502ec 
closes #15068 , #15306
@heaths
Copy link
Member

heaths commented Oct 6, 2020

Resolved by PR #15720

@heaths heaths closed this as completed Oct 6, 2020
@Tianyun-G
Copy link
Contributor Author

@heaths - This PR #15720 resolved Azure.Security.KeyVault.Keys issue but not Azure.Security.KeyVault.Administration Readme issues #15306. So we should reopen this issue.

suhas92 pushed a commit to suhas92/azure-sdk-for-net that referenced this issue Oct 12, 2020
@christothes @suhas92
Add instructions to README for Managed HSM (Azure#15720)
6cab2aa 
closes Azure#15068 , Azure#15306
@heaths
Copy link
Member

heaths commented Oct 13, 2020

That PR changed .Administration as well: https://github.com/Azure/azure-sdk-for-net/pull/15720/files#diff-38d081175459e2bc24160047f4061d161cd27d840ac763b00f76ff7c6331ecbb

If you still see issues, can you describe them specifically?

@Tianyun-G
Copy link
Contributor Author

@heaths - The issues in the picture haven't been resolved #15306 .
image

@heaths
Copy link
Member

heaths commented Oct 13, 2020

Does this render correctly? The source markdown shouldn't matter.

@Tianyun-G Tianyun-G mentioned this issue Oct 14, 2020
Merged
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@christothes @annelo-msft
Add instructions to README for Managed HSM (Azure#15720)
955f53a 
closes Azure#15068 , Azure#15306
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christothes christothes

Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Projects
None yet
Milestone
[2020] October
Development

No branches or pull requests
6 participants
@christothes @heaths @AlexanderSher @schaabs @tzhanl @Tianyun-G