Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Consider making collections returned by service methods pageables #15927

Closed
kinelski opened this issue Oct 13, 2020 · 0 comments · Fixed by #16049
Closed

[MetricsAdvisor] Consider making collections returned by service methods pageables #15927

kinelski opened this issue Oct 13, 2020 · 0 comments · Fixed by #16049
Assignees
@kinelski
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2020] November

Comments

@kinelski
Copy link
Member

kinelski commented Oct 13, 2020 •
edited
Loading

Some service methods return IReadOnlyList. We could:

  1. Wrap them in pageables. We'll only make 1 service call, and skip/top/pageSize would not be supported.
  2. Wrap them in collections, like we do in Form Recognizer. We would need to create a new Collection type for every possible return type.

Edit: we'll wrap them in pageables for consistency across methods and across languages. They were wrapped in collections in Form Recognizer because returning pageables from Long-Running Operations would require extra engineering work.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Oct 13, 2020
@kinelski kinelski modified the milestones: Backlog, [2020] November Oct 13, 2020
@kinelski kinelski mentioned this issue Oct 16, 2020
Merged
@kinelski kinelski self-assigned this Oct 30, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Sep 7, 2021
@chsamala
CodeGen from PR 15927 in Azure/azure-rest-api-specs
1f0e300 
Changes to fix the SDK generation with latest API version (Azure#15927)

* Adding diable local auth in PUT payload

* Adding diable local auth in PUT payload

* fixing md file to generate right SDK files

Co-authored-by: Sekhar Samala <chsamala@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Make collections returned by service methods pageables kinelski/azure-sdk-for-net
1 participant
@kinelski