Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test failure] Cancels_OnlySlow #15936

Closed
pakrym opened this issue Oct 13, 2020 · 4 comments · Fixed by #15942
Closed

[Test failure] Cancels_OnlySlow #15936

pakrym opened this issue Oct 13, 2020 · 4 comments · Fixed by #15942
Assignees
@Mohit-Chakraborty
Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable
Milestone
Backlog

Comments

@pakrym
Copy link
Contributor

pakrym commented Oct 13, 2020 


Error message
Expected: False
But was:  True


Stack trace
   at Azure.Search.Documents.Tests.AsyncEventExtensionsTests.Cancels_OnlySlow() in /Users/runner/work/1/s/sdk/search/Azure.Search.Documents/tests/Batching/AsyncEventExtensionsTests.cs:line 450

https://dev.azure.com/azure-sdk/public/_build/results?buildId=572950&view=ms.vss-test-web.build-test-results-tab&runId=14102406&resultId=100472&paneView=debug
@pakrym pakrym added Search Client This issue points to a problem in the data-plane of the library. labels Oct 13, 2020
@pakrym pakrym mentioned this issue Oct 13, 2020
Merged
@heaths
Copy link
Member

heaths commented Oct 13, 2020

Timing-based tests are the worst. For this, I will just increase the "slow test" delay a little and hope that helps.

/cc @tg-msft

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Oct 13, 2020
@heaths
Increase timeout for Cancels_OnlySlow test
1dc92a8 
Fixes Azure#15936
@heaths heaths mentioned this issue Oct 13, 2020
Merged
heaths added a commit that referenced this issue Oct 13, 2020
@heaths
Fix some sporadically failing Search tests (#15942)
14a2fc9 
* Increase timeout for Cancels_OnlySlow test

Fixes #15936

* Add delay before checking doc count again

Timing of replicas can impact document counts in a cluster. This delay on a free SKU should help according to @brjohnstmsft. We could also upgrade to a basic SKU, but there'll be additional costs, availability, and provisioning time associated.
@pakrym pakrym reopened this Nov 23, 2020
@pakrym
Copy link
Contributor Author

pakrym commented Nov 23, 2020

Still flaky https://dev.azure.com/azure-sdk/public/_build/results?buildId=630141&view=ms.vss-test-web.build-test-results-tab&runId=15139896&resultId=110779&paneView=debug

@heaths
Copy link
Member

heaths commented Nov 23, 2020

@tg-msft can you please take a look at this class of timing-related issues with batching?

@heaths heaths assigned tg-msft and unassigned heaths Nov 23, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@heaths @annelo-msft
Fix some sporadically failing Search tests (Azure#15942)
b3c6531 
* Increase timeout for Cancels_OnlySlow test

Fixes Azure#15936

* Add delay before checking doc count again

Timing of replicas can impact document counts in a cluster. This delay on a free SKU should help according to @brjohnstmsft. We could also upgrade to a basic SKU, but there'll be additional costs, availability, and provisioning time associated.
@AlexGhiondea AlexGhiondea added this to the [2021] June milestone May 3, 2021
@AlexGhiondea AlexGhiondea modified the milestones: [2021] June, [2021] July Jun 9, 2021
@jsquire jsquire modified the milestones: [2021] July, Backlog Jul 16, 2021
@jsquire jsquire added test-reliability Issue that causes tests to be unreliable and removed Test Debt labels Jul 16, 2021
@JoshLove-msft
Copy link
Member

Hasn't failed in a while, closing.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mohit-Chakraborty Mohit-Chakraborty

Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix some sporadically failing Search tests heaths/azure-sdk-for-net
7 participants
@jsquire @tg-msft @heaths @pakrym @Mohit-Chakraborty @AlexGhiondea @JoshLove-msft