Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if we can modify swagger pagination definition so we get nextpage methods for free #18373

Closed
maririos opened this issue Feb 3, 2021 · 6 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone

Comments

@maririos
Copy link
Member

maririos commented Feb 3, 2021

If for whatever reason we can't on the service side, see if we can with transforms.
Also, undo this =>#18351 (comment)

@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Feb 3, 2021
@maririos maririos added this to the [2021] March milestone Feb 3, 2021
@maririos
Copy link
Member Author

maririos commented Feb 3, 2021

See #18351 (comment)

@maririos
Copy link
Member Author

maririos commented Mar 3, 2021

The service is looking into adding showStats to the nextlink property. Once that is enabled, the fix in the swagger is easier for all languages.
For now .NET will do transforms

@maririos
Copy link
Member Author

maririos commented Mar 5, 2021

All pagination is now done automatically. Will move this issue for next milestone to keep following up so eventually we can remove the transforms in .NET

@maririos maririos modified the milestones: [2021] March, [2021] April Mar 5, 2021
@maririos
Copy link
Member Author

maririos commented Mar 9, 2021

@maririos
Copy link
Member Author

maririos commented Mar 24, 2021

Giving it a try in the swagger so we can remove the transforms on each language.
Draft PR Azure/azure-rest-api-specs#13615

@maririos maririos modified the milestones: [2021] April, [2021] May Apr 1, 2021
@maririos
Copy link
Member Author

After trying different approaches, the way the other languages are generating pageable, they depend on properties like value or items inside the response. The way TA works is that the whole response object is the one that is pageable and although .NET can handle this, the other languages can't.
So sadly, I'm going to have to close this issue and leave the transformations in the .NET autorest.md file :(

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

No branches or pull requests

1 participant