[TA] Delete custom HealthStatusNextPageAsync for in health pagination #19183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maririos
commented
Mar 3, 2021
| /// <param name="showStats"> (Optional) if set to true, response will contain request and document level statistics. </param> | ||
| /// <param name="cancellationToken"> The cancellation token to use. </param> | ||
| /// <exception cref="ArgumentNullException"> <paramref name="nextLink"/> is null. </exception> | ||
| public async Task<Response<HealthcareJobState>> HealthStatusNextPageNextPageAsync(string nextLink, bool? showStats = null, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
this is created twice and it has already been reported: Azure/autorest.csharp#1056
I made the name very very ugly so no one uses it :P
maririos
commented
Mar 3, 2021
suhas92
approved these changes
Mar 4, 2021
ShivangiReja
reviewed
Mar 4, 2021
ShivangiReja
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #18373
Currently I manually wrote
HealthStatusNextPageAsyncandHealthStatusNextPagefunctions in order to have pagination in Health because we were not getting them from the swagger or codegen. This change is doing transformations in order to generate it automatically so we can delete my manual code.Two action items I am still working on:
nextlinkdoesn't include theshowStats(they have opened an issue)In a future PR I will do the same for Analyze endpoint