[Perf] Perf Framework should only ignore OperationCanceledException if cancellationToken is cancelled #21241

mikeharder · 2021-05-20T20:50:23Z

Currently, the perf framework ignores all exceptions which contain OperationCanceledException in the chain:

azure-sdk-for-net/common/Perf/Azure.Test.Perf/PerfProgram.cs

Lines 485 to 488 in 835bf84

    
           catch (Exception e) 
        
           { 
        
               // Ignore if any part of the exception chain is type OperationCanceledException 
        
               if (!PerfStressUtilities.ContainsOperationCanceledException(e))

This should be tightened to only ignore if cancellationToken.IsCancellationRequested is true. The goal is to only ignore the exception that may be thrown when the last in-flight operation is cancelled.

The text was updated successfully, but these errors were encountered:

Migrate to net track2 for some resource-manager readmes batch 3 (Azure#21241) * migrate to track 2 * revert configs for machinelearning and managementgroups * resolve Go SDK automation failure Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

mikeharder added pillar-performance The issue is related to performance, one of our core engineering pillars. Central-EngSys This issue is owned by the Engineering System team. labels May 20, 2021

mikeharder self-assigned this May 20, 2021

mikeharder mentioned this issue May 21, 2021

Only ignore OperationCanceledException if cancellationToken is cancelled #21250

Merged

mikeharder closed this as completed in #21250 May 21, 2021

github-actions bot locked and limited conversation to collaborators Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Perf] Perf Framework should only ignore OperationCanceledException if cancellationToken is cancelled #21241

[Perf] Perf Framework should only ignore OperationCanceledException if cancellationToken is cancelled #21241

mikeharder commented May 20, 2021

[Perf] Perf Framework should only ignore OperationCanceledException if cancellationToken is cancelled #21241

[Perf] Perf Framework should only ignore OperationCanceledException if cancellationToken is cancelled #21241

Comments

mikeharder commented May 20, 2021