Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Delete Sample: delete tags before manifests #21675

Closed
annelo-msft opened this issue Jun 7, 2021 · 0 comments · Fixed by #22138
Closed

[ACR] Delete Sample: delete tags before manifests #21675

annelo-msft opened this issue Jun 7, 2021 · 0 comments · Fixed by #22138
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone
[2021] July

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Jun 7, 2021 •
edited
Loading

Confirming with @mnltejaswini that this is the recommended best practice for the service.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels Jun 7, 2021
@annelo-msft annelo-msft added this to the [2021] July milestone Jun 7, 2021
@annelo-msft annelo-msft mentioned this issue Jun 7, 2021
Closed
@annelo-msft annelo-msft changed the title Delete Sample: delete tags before manifests [ACR] Delete Sample: delete tags before manifests Jun 7, 2021
@jeremymeng jeremymeng mentioned this issue Jun 17, 2021
Closed
2 tasks
@annelo-msft annelo-msft mentioned this issue Jun 24, 2021
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Jan 4, 2023
@srcharug @csassasin
@johnzhang-microsoft @avaiyanggarg @parahluwalia @RajalakshmiSwaminathan @sds6
CodeGen from PR 21571 in Azure/azure-rest-api-specs
f8bb30e 
Feature/cplat 2022 11 01 (Azure#21571)

* add 2022-11-01 folder

* update readme, update version reference

* Added userData property for PUT Restore Point API

Added user data property for PUT Restore Point API

* Revert "Added userData property for PUT Restore Point API"

This reverts commit 94c96d8ca8586b37a59083efd6357ccf2594dd61.

* Reimage Support for Non-Ephemeral VMs (Azure#21090)

* Reimage support for non-ephemeral VMs

* small changes

* small changes

* resolving issues

* pretty check

* pretty install

* remove package-lock

* remove package-lock

* Added userData property in Restore Point PUT API endpoint (Azure#21262)

* Added userData property in Restore Point PUT Operation

* Update based on review comment

* Updated description

Co-authored-by: Ashwani Tiwari <ashwtiwari@microsoft.com>

* Add OS Image profile to scheduled events profile and maxSurge in rolling upgrade policy in Microsoft.Compute (Azure#21253)

* add reimage notification

* update reimage notification, add max surge

* fix grammar

* Adding requireGuestProvisionSignal and constrainedMaximumCapacity mis… (Azure#21433)

* Adding requireGuestProvisionSignal and constrainedMaximumCapacity missing properties

* Moved the property at the end

Co-authored-by: Avaiyang Garg <avaiyanggarg@micrososft.com>

* Add serviceArtifactReference property (Azure#21607)

* Add serviceArtifactReference property

* Moved the property inside the virtualMachineScaleSet file

* Minor change in example

Co-authored-by: Avaiyang Garg <avaiyanggarg@micrososft.com>

* add platformFaultDomain in instanceView (Azure#21605)

* add platformFaultDomain in instanceView

* change platformFaultDomain values

* add APIVersionPattern Suppression (Azure#21675)

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Adding imageDeprecationStatus properties to VirtualMachineImage response (Azure#21615)

* Changes to virtualMachineImage.json to include ImageDeprecationStatus properties

* Changes to example json

* Fixed LintDiff errors

* Addressed review comment

* Introduce rollbackFailedInstancesOnPolicyBreach in VMSS RollingUpgradePolicy  (Azure#21676)

* add property in compute.json

* add in 2022 file

* add rollbackFailedInstancesOnPolicyBreach in examples

* Revert "add property in compute.json"

This reverts commit 15a1e10503cc4e34b0b69f351cc8f23339002360.

* remove space

Co-authored-by: Sachin Doddaiah Shylaja <sadoddai@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>

* fix spellingCheck error, LintDiff error, model validation, and typo

* fix modelValidation

* model validation

* update headers for examples

* model validation errors

* model validation

* Revert "model validation"

This reverts commit d3810a7866a9093b6ef75a57834e1aaeb4e139f3.

* Revert "model validation errors"

This reverts commit ba34d1b2af2bef58b60c16e9ed1cda00803a2ce0.

* Revert "update headers for examples"

This reverts commit 216b3dc1367655b8c7867a9d7a772fe7e2fa1583.

* Revert "model validation"

This reverts commit 285345656321e984bc99486a575e35a4d3359667.

* Revert "fix modelValidation"

This reverts commit a5fa156d42130566b827df88d6dea4ee591f4a6c.

* Revert "fix spellingCheck error, LintDiff error, model validation, and typo"

This reverts commit 9f60b71000be72bf4511feefcda0820b570345de.

* fix spelling error CI, file name typo, Lint Diff

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Ashwani Tiwari <ashwtiwari@microsoft.com>
Co-authored-by: srcharug <62158390+srcharug@users.noreply.github.com>
Co-authored-by: csassasin <89677872+csassasin@users.noreply.github.com>
Co-authored-by: John Zhang <116316220+johnzhang-microsoft@users.noreply.github.com>
Co-authored-by: avaiyanggarg <116031789+avaiyanggarg@users.noreply.github.com>
Co-authored-by: Avaiyang Garg <avaiyanggarg@micrososft.com>
Co-authored-by: parahluwalia <117622623+parahluwalia@users.noreply.github.com>
Co-authored-by: RajalakshmiSwaminathan <raswamin@microsoft.com>
Co-authored-by: Sachin Doddaiah Shylaja <sachin.ds92@gmail.com>
Co-authored-by: Sachin Doddaiah Shylaja <sadoddai@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

Update Delete Sample annelo-msft/azure-sdk-for-net
1 participant
@annelo-msft