Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Don't cancel autolockrenewal on StopProcessingAsync call #22143

Closed
JoshLove-msft opened this issue Jun 24, 2021 · 0 comments · Fixed by #22257
Closed

[BUG] Don't cancel autolockrenewal on StopProcessingAsync call #22143

JoshLove-msft opened this issue Jun 24, 2021 · 0 comments · Fixed by #22257
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@JoshLove-msft
Copy link
Member

Quoting from #21869 (comment):

During shutdown, you cancel this task immediately even if message is still being processed in message handler. In case of auto complete message you always try to complete it, but lock can be already lost. Is there real reason not to cancel lock renewal after all message handling is done ?

@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jun 24, 2021
@JoshLove-msft JoshLove-msft added this to the [2021] July milestone Jun 24, 2021
@JoshLove-msft JoshLove-msft self-assigned this Jun 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant