Continue renewing lock while processing #22257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Jun 29, 2021
| }); | ||
|
|
||
| int receivedCount = 0; | ||
| var tcs = new TaskCompletionSource<bool>(); |
There was a problem hiding this comment.
Suggested change
| var tcs = new TaskCompletionSource<bool>(); | |
| var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously); |
There was a problem hiding this comment.
Ah I had auto-merge enabled, but I don't think this will be a huge impact being that this is a test rather than the produce code.
| var ct = Interlocked.Increment(ref receivedCount); | ||
| if (ct == messageCount) | ||
| { | ||
| tcs.SetResult(true); |
There was a problem hiding this comment.
Suggested change
| tcs.SetResult(true); | |
| tcs.TrySetResult(true); |
There was a problem hiding this comment.
Probably not necessary due to the increment, but can't hurt.
There was a problem hiding this comment.
This shouldn't be necessary and could potentially obscure other issues in the test.
| }); | ||
|
|
||
| int receivedCount = 0; | ||
| var tcs = new TaskCompletionSource<bool>(); |
There was a problem hiding this comment.
Suggested change
| var tcs = new TaskCompletionSource<bool>(); | |
| var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously); |
| var ct = Interlocked.Increment(ref receivedCount); | ||
| if (ct == messageCount) | ||
| { | ||
| tcs.SetResult(true); |
There was a problem hiding this comment.
Suggested change
| tcs.SetResult(true); | |
| tcs.TrySetResult(true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22143