Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable spellchecker #22917

Closed
maririos opened this issue Jul 27, 2021 · 3 comments
Closed

Enable spellchecker #22917

maririos opened this issue Jul 27, 2021 · 3 comments
Assignees
@AhmedLeithy
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator
Milestone
[2021] August

Comments

@maririos
Copy link
Member

In order to enable spell checker, we need to add SpellCheckPublicApiSurface: true to https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/translation/ci.yml#L25.

To run the tool, run eng\scripts\Export-API.ps1 -SpellCheckPublicApiSurface translation.
If there are errors, we need to fix them. If there are false positives, we need to add them to https://github.com/Azure/azure-sdk-for-net/blob/main/.vscode/cspell.json#L68

Part of #17798
@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Translator labels Jul 27, 2021
@maririos maririos added this to the [2021] August milestone Jul 27, 2021
@AhmedLeithy
Copy link
Member

I ran the tool and there are no errors to be found.

image

@maririos
Copy link
Member Author

Awesome!!
We will still need to enable it for our live tests.
You will have to create a PR with the changes:

In order to enable spell checker, we need to add SpellCheckPublicApiSurface: true to https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/translation/ci.yml#L25.

@AhmedLeithy AhmedLeithy mentioned this issue Jul 30, 2021
Merged
@AhmedLeithy
Copy link
Member

Yes of course, I forgot to PR the change. I have created the PR #22992.

@maririos maririos mentioned this issue Jul 30, 2021
Closed
17 tasks
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Mar 6, 2023
CodeGen from PR 22797 in Azure/azure-rest-api-specs
394fbb1 
[Hub Generated] Review request for Microsoft.Security to add version preview/2023-02-01-preview (Azure#22797)

* Adds base for updating Microsoft.Security from version preview/2020-07-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update new API version (Azure#22705)

* Remove versioning (Azure#22745)

* Updade readme (Azure#22871)

* Updade readme

* Trigger new validations

* Remove old swaggers from default tag (Azure#22917)
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AhmedLeithy AhmedLeithy

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator
Projects
None yet
Milestone
[2021] August
Development

No branches or pull requests
2 participants
@maririos @AhmedLeithy