OcrResult variable Language of the wrong type.

[dumonjorne]

Hi,

In Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Models.OcrResult, variable Language is of the wrong type, resulting in a failing json deserialization. It should be of type OcrLanguage instead of OcrResult.

[brminnick]

Here's my workaround for anyone else who is struggling with this error.

I created my own OcrResultModel that uses the correct type, OcrLanguages. I then create a new OcrResult, assigning Language = default(OcrResult)

Here's a link to my Xamarin app where I use this workaround: https://github.com/brminnick/XamSpeak/blob/master/Source/XamSpeak/Services/OCRServices.cs#L33

public static async Task<OcrResult> GetOcrResultsFromMediaFile(MediaFile mediaFile)
{
	try
	{
		return await ComputerVisionApiClient.RecognizePrintedTextInStreamAsync(true, ConverterHelpers.ConvertMediaFileToStream(mediaFile, false)).ConfigureAwait(false);
	}
	catch (ComputerVisionErrorException e) when (e.Response.StatusCode.Equals(HttpStatusCode.Unauthorized))
	{
		DebugHelpers.PrintException(e);

		OnInvalidComputerVisionAPIKey();

		throw;
	}
        catch (Microsoft.Rest.SerializationException e)
	{
		var xamSpeakOcrResult = JsonConvert.DeserializeObject<XamSpeakOcrResult>(e.Content);

		return new OcrResult
		{
			Language = default(OcrResult),
			Orientation = xamSpeakOcrResult.Orientation,
			Regions = xamSpeakOcrResult.Regions,
                        TextAngle = xamSpeakOcrResult.TextAngle
		};
	}
}

using System.Collections.Generic;

using Newtonsoft.Json;

using Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Models;

namespace XamSpeak
{
	public class XamSpeakOcrResult
	{
		[JsonProperty("language")]
		public OcrLanguages Language { get; set; }

		[JsonProperty("orientation")]
		public string Orientation { get; set; }

		[JsonProperty("textAngle")]
		public double TextAngle { get; set; }

		[JsonProperty("regions")]
		public List<OcrRegion> Regions { get; set; }
	}
}

[brminnick]

To fix this bug, change this line of code in the SDK:

azure-sdk-for-net/src/SDKs/CognitiveServices/dataPlane/Vision/ComputerVision/ComputerVision/Generated/Models/OcrResult.cs

Line 66 in c95d9ea

public OcrResult Language { get; set; }

Change
public OcrResult Language { get; set; }
To
public OcrLanguages Language { get; set; }