[FormRecognizer] Preview 1: throw RequestFailedException when long-running operation has failed #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Cognitive Services
Client
kinelski
commented
Apr 20, 2020
kinelski
commented
Apr 20, 2020
annelo-msft
reviewed
Apr 20, 2020
sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 20, 2020
sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 20, 2020
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 20, 2020
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Show resolved
Hide resolved
maririos
reviewed
Apr 21, 2020
...cognizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 21, 2020
sdk/formrecognizer/Azure.AI.FormRecognizer/src/RecognizeCustomFormsOperation.cs
Show resolved
Hide resolved
annelo-msft
reviewed
Apr 21, 2020
| @@ -102,9 +102,6 @@ private async ValueTask<Response> UpdateStatusAsync(bool async, CancellationToke | |||
| ? await _serviceClient.GetAnalyzeLayoutResultAsync(new Guid(Id), cancellationToken).ConfigureAwait(false) | |||
| : _serviceClient.GetAnalyzeLayoutResult(new Guid(Id), cancellationToken); | |||
|
|
|||
| // TODO: Handle correctly according to returned status code | |||
| // https://github.com/Azure/azure-sdk-for-net/issues/10386 | |||
|
|
|||
There was a problem hiding this comment.
Would it make sense to handle a Failed OperationStatus the same way for receipts and content as we're doing in custom form? If the operation failed for some reason, we might similarly throw the wrong exception type here by trying to deserialize the PageResults & ReadResults from the response body.
If we don't know of an instance of this happening in the service currently, it would be good to file an issue to track it for Preview 3.
There was a problem hiding this comment.
I think that filing an issue is a good idea. Like you suggested, I'm not aware of a scenario where this could be an issue. Receipt and content recognition seem to be way more resilient to these kind of errors than the custom endpoint.
annelo-msft
reviewed
Apr 21, 2020
annelo-msft
approved these changes
Apr 21, 2020
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes properly handle "operation failed" scenarios in which an unexpected 200 HTTP status code is returned from the service. A
RequestFailedExceptionis being thrown when this happens.Fixes #10334.
Addresses #10625, but tests could still be needed (under discussion).