Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified XML comments for direct method APIs #11923

Merged
merged 1 commit into from
May 8, 2020
Merged

Modified XML comments for direct method APIs #11923

merged 1 commit into from
May 8, 2020

Conversation

abhipsaMisra
Copy link
Member

@abhipsaMisra abhipsaMisra commented May 7, 2020 •
edited
Loading

The diffs are highlighted in this commit: 3264d23

Rebased from latest swagger.

@abhipsaMisra abhipsaMisra force-pushed the feature/iot/abmisr/directMethodComments branch from 6e70740 to 026cd59 Compare May 8, 2020 18:35
timtay-microsoft
timtay-microsoft approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@timtay-microsoft timtay-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, but otherwise looks good

@abhipsaMisra abhipsaMisra force-pushed the feature/iot/abmisr/directMethodComments branch from d15ea57 to 3264d23 Compare May 8, 2020 18:50
@timtay-microsoft
Copy link
Member

timtay-microsoft commented May 8, 2020 •
edited
Loading

I put the swagger spacing fix in my PR and merged it, so you can rebase your branch now to simplify what this PR looks like for your reviewers

@abhipsaMisra
Copy link
Member Author

I put the swagger spacing fix in my PR and merged it, so you can rebase your branch now to simplify what this PR looks like for your reviewers

Is your PR merged in? I didn't get a chance to review it yet! 😟

@timtay-microsoft
Copy link
Member

timtay-microsoft commented May 8, 2020 •
edited
Loading

I put the swagger spacing fix in my PR and merged it, so you can rebase your branch now to simplify what this PR looks like for your reviewers

Is your PR merged in? I didn't get a chance to review it yet! 😟

Ah, sorry. Priyanka and Binal signed off on it already, so I merged it. I'd be happy to create a new PR if you have any comments. You can still leave those comments on my original PR: #11927

@abhipsaMisra
Copy link
Member Author

Ah, sorry. Priyanka and Binal signed off on it already, so I merged it. I'd be happy to create a new PR if you have any comments. You can still leave those comments on my original PR: #11927

No worries, I'll review it now.

@abhipsaMisra abhipsaMisra force-pushed the feature/iot/abmisr/directMethodComments branch from 3264d23 to 6ccc0dd Compare May 8, 2020 19:22
@abhipsaMisra abhipsaMisra merged commit d133350 into feature/iot/swaggerFixesComments May 8, 2020
@abhipsaMisra abhipsaMisra deleted the feature/iot/abmisr/directMethodComments branch May 8, 2020 20:25
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Dec 4, 2020
CodeGen from PR 11923 in Azure/azure-rest-api-specs
a0e98e9 
add storagesync track2 config (Azure#11923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@vinagesh vinagesh vinagesh approved these changes

@bikamani bikamani bikamani approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhipsaMisra @timtay-microsoft @vinagesh @bikamani