Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reserved instances] Added new products to enum ReservedResourceType #13396

Closed
wants to merge 1 commit into from

Conversation

aditink
Copy link

@aditink aditink commented Jul 11, 2020

The reserved instances team has onboarded new products. This change reflects the addition.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aditink when generating management plane .net sdk, please follow our guidelines. Make sure you:

  • Generate with generate.ps1, which also produces a metadata txt under eng/mgmt/mgmtmetadata that needs to be checked in
  • Update release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Jul 13, 2020
@isra-fel
Copy link
Member

Kindly ping @aditink

@aditink
Copy link
Author

aditink commented Jul 21, 2020

It looks like I have to make updates to RestAPI specs repo first; will open a new pull request after doing so.
Thanks!

@aditink aditink closed this Jul 21, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Jul 16, 2021
track2 configure (Azure#13396)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants