Update AutoRest C# version #14407
Update AutoRest C# version #14407
Conversation
azure-sdk
requested review from
abhipsaMisra,
AlexanderSher,
AlexGhiondea,
allenjzhang,
amishra-dev,
amnguye,
annelo-msft,
arv100kri,
azabbasi,
barustum,
bikamani,
bleroy,
brjohnstmsft,
chidozieononiwu,
christothes,
danieljurek,
dkulkarni-ms,
drwill-ms,
grizzlytheodore,
haagha,
heaths,
jsquire,
kasobol-msft,
kinelski,
madewithsmiles,
maririos,
mitchdenny,
MS-syh2qs and
prmathur-microsoft
as code owners
| @@ -76,6 +76,7 @@ internal HttpMessage CreateCreateOrUpdateRequest(string dataSourceName, SearchIn | |||
| request.Headers.Add("Prefer", "return=representation"); | |||
| request.Headers.Add("Accept", "application/json; odata.metadata=minimal"); | |||
| request.Headers.Add("Content-Type", "application/json"); | |||
| request.Headers.Add("Accept", "application/json"); | |||
There was a problem hiding this comment.
This still isn't fixed. We can't ship this way because it changes the output. Which, BTW, you wouldn't have to re-record - and probably shouldn't to not only reduce the git database size, but even just trying to review this PR in a browser on github.com (I'm using VSCode because the browser hangs trying to open this)
| @@ -76,6 +76,7 @@ internal HttpMessage CreateCreateOrUpdateRequest(string dataSourceName, SearchIn | |||
| request.Headers.Add("Prefer", "return=representation"); | |||
| request.Headers.Add("Accept", "application/json; odata.metadata=minimal"); | |||
| request.Headers.Add("Content-Type", "application/json"); | |||
| request.Headers.Add("Accept", "application/json"); | |||
There was a problem hiding this comment.
Yes - here's the invalid output in the recordings. I'm surprised the server even responded - maybe it used the first one? We shouldn't gamble that's consistent or even supported:
"Entries": [
{
"RequestUri": "https://azs-net-t50d8619e0b774b52.search.windows.net/indexes(\u0027irggcyth\u0027)/docs/search.post.autocomplete?api-version=2020-06-30",
"RequestMethod": "POST",
"RequestHeaders": {
"Accept": [
"application/json; odata.metadata=none",
"application/json"
],
|
@heaths not planning to merge this without a bug fix. Just making sure all projects are in a re-recordable state. |
sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Azure.Analytics.Synapse.Artifacts.csproj
Show resolved
Hide resolved
|
@pakrym once the bug fix is in, might be good to back out the recorded sessions then and make sure the tests pass without re-recording, or is that the idea already? |
Yep, that's the idea. |
| @@ -50,3 +56,4 @@ | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: is the auto-updater adding a blank line to the end everytime it updates? Might be good to stop that eventually.
not-specified