Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]Delete 1 file in Extensions dic and add maxRowPerFile/fileNamePrefix to tabular format settings #15287

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Sep 21, 2020

@YalinLi0312
Copy link
Member

YalinLi0312 commented Sep 21, 2020

Hi @Jingshu923, here have two questions:

  • Why you remove the file in src/Extenisons? Do you restore the file in another path? Otherwise, it would cause a breaking change.
  • Could you update versions in *.csproj and AssemblyInfo.cs if you are going to release?

Additionally, if you can update the pr name to a more descriptive one other than SDK change in 09.21 would be better.

Thanks

@Jingshu923
Copy link
Contributor Author

Hi @YalinLi0312 , for #1 The files I deleted in src/Extenisons have been restored in src/Models dic, It will not cause break changes.
for #2 The versions has been updated in previous PR, so this PR need not update the versions.

BTW, could you response my question in my email why the models could not generate the attribute of JsonObject when model name is the same with ‘x-ms-discriminator-value’ value. e.g 'WebActivity'.

@Jingshu923 Jingshu923 changed the title [DataFactory]SDK change in 09.21 [DataFactory]Delete 7 files in Extensions dic and add maxRowPerFile/fileNamePrefix to tabular format settings Sep 22, 2020
@Jingshu923 Jingshu923 changed the title [DataFactory]Delete 7 files in Extensions dic and add maxRowPerFile/fileNamePrefix to tabular format settings [DataFactory]Delete 1 file in Extensions dic and add maxRowPerFile/fileNamePrefix to tabular format settings Sep 22, 2020
@Jingshu923
Copy link
Contributor Author

@YalinLi0312 delete TabularPartitionOption file due swagger has delete this model and sdk has no referrences with this file, so there is no break change.

@allenjzhang
Copy link
Member

allenjzhang commented Sep 22, 2020

delete TabularPartitionOption file due swagger has delete this model and sdk has no referrences with this file, so there is no break change.

@Jingshu923, Our definitions of breaking change is different. Breaking change for us means that new version will break customer's code (compile/runtime) and require user to modify the code, recompile and re-deploy. So yes, this is a breaking change for SDK even though it is intentional breaking change originated from REST API model change.

@allenjzhang allenjzhang merged commit 18fd9e2 into Azure:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants