Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit for DedicatedHostGroup's PlatformFaultDomainCount and DedicatedHost's PlatformFaultDomain #15377

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

dochung4
Copy link
Contributor

No description provided.

@dochung4
Copy link
Contributor Author

Swagger PR: Azure/azure-rest-api-specs#10813

@dochung4
Copy link
Contributor Author

@bquantump , can you please review?

Copy link
Member

@bquantump bquantump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like this needs to be a version change, please follow this check list:

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
  • Release notes in *.csproj is updated
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
  • Generated code is not touched

@bquantump
Copy link
Member

@dochung4 Any update here? Else I will close this.

@dochung4
Copy link
Contributor Author

dochung4 commented Oct 4, 2020

@bquantump , I pushed a new iteration. Please take a look.

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
    -> Swagger PR: Remove maximum for DedicatedHostGroup azure-rest-api-specs#10813, which has already been merged. I am not sure whether there is a separate place for "PR description", but if there is, please let me know.
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
    -> Done
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
    -> Done
  • Release notes in *.csproj is updated
    -> Done
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
    -> There is no API-version update
  • Generated code is not touched
    -> If you are referring to "sdk\compute\Microsoft.Azure.Management.Compute\src\Generated", then it is actually expected to be touched, and I confirm that the changes there are correct.

@dochung4
Copy link
Contributor Author

dochung4 commented Oct 7, 2020

@bquantump , can you please review?

@bquantump bquantump merged commit fdcc2c0 into Azure:master Oct 8, 2020
suhas92 pushed a commit to suhas92/azure-sdk-for-net that referenced this pull request Oct 12, 2020
…and DedicatedHost's PlatformFaultDomain (Azure#15377)

* Updated

* Addressed comments
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
…and DedicatedHost's PlatformFaultDomain (Azure#15377)

* Updated

* Addressed comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants