Various API Renames #15593
Merged
Various API Renames #15593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
jsquire,
KrzysztofCwalina,
MiYanni,
ShivangiReja and
tg-msft
as code owners
ghost
added
the
jsquire
approved these changes
Oct 1, 2020
| @@ -99,7 +99,7 @@ internal class AmqpClient : TransportClient | |||
| ServiceEndpoint, | |||
| credential, | |||
| options.TransportType, | |||
| options.Proxy); | |||
| options.WebProxy); | |||
There was a problem hiding this comment.
I'm not sure where this came from, but I question the drift from the naming for the same concept in Event Hubs across the languages.
There was a problem hiding this comment.
This was based on a comment from Clemens in the Api View.
| { | ||
| entry[ManagementConstants.Properties.ViaPartitionKey] = message.ViaPartitionKey; | ||
| entry[ManagementConstants.Properties.ViaPartitionKey] = message.TransactionPartitionKey; |
There was a problem hiding this comment.
nit: Should the constant member also be renamed to match?
sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClientOptions.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Outdated
Show resolved
Hide resolved
MiYanni
approved these changes
Oct 1, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make MaxReceiveTime internal within the ProcessorOptions.
Update entity name exception message.
Fixes #14986, #14975, #10646