Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address PR comments #15616

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Address PR comments #15616

merged 5 commits into from
Oct 1, 2020

Conversation

christothes
Copy link
Member

Comments from #15546

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Oct 1, 2020
@christothes christothes self-assigned this Oct 1, 2020
kinelski
kinelski approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the unused constructor that takes a MetricId, non-blocking. LGTM.

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorClient.cs Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorClient.cs Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/Metrics/GetMetricFeedbacksOptions.cs Outdated Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/Metrics/GetMetricFeedbacksOptions.cs Outdated Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/Metrics/MetricAnomalyFeedback.cs Outdated Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/Metrics/MetricChangePointFeedback.cs Outdated Show resolved Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/Metrics/MetricCommentFeedback.cs Outdated Show resolved Hide resolved
@christothes christothes merged commit a64829f into Azure:master Oct 1, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@christothes @annelo-msft
Address PR comments (Azure#15616)
ff4b74a 
* Address PR comments

* rename back to GetMetricFeedbacks

* export

* pr comments

* export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinelski kinelski kinelski approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees

@christothes christothes

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christothes @kinelski @jsquire