Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten code required to instrument options #15698

Merged
3 commits merged into from
Oct 5, 2020

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Oct 5, 2020

Fixes: #15692

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core, KV, and Search LGTM

@pakrym
Copy link
Contributor Author

pakrym commented Oct 5, 2020

/azp run net - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Oct 5, 2020

Hello @pakrym!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 134e902 into Azure:master Oct 5, 2020
JoshLove-msft pushed a commit that referenced this pull request Oct 22, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move InstrumentClientOptions to RecordedTestBase
6 participants