Data collection rules 2019-11-01-preview #15789
Conversation
herreraj-ms
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
| #region DCR Tests | ||
| [Fact] | ||
| [Trait("Category", "Mock")] | ||
| public void CreateDataCollectionRuleTest() |
There was a problem hiding this comment.
Why are these tests mocked rather than using the test recording mechanism?
There was a problem hiding this comment.
In the instructions, is mention "Add or update tests for the newly generated code" but it's not specific.
I took an example of another Test and adjust accordingly.
Should I remove this file?
For the recording mechanism, Is the json file created manually? or there's a tool/procedure for creating it?
There was a problem hiding this comment.
The advantage of the recording mechanism is that it records responses during live tests with the service, and whenever the api-version changes, the recording is invalidated and you have to re-run the tests live. In this case, maintainers of the test will have to compare the mocked responses with service responses each time there is a chance, which increases the chance of confusion and errors.
It is appropriate to use fully mocked responses like this to simulate responses that are difficult to get from the live service (for example, to siulate handling of 409 errors). If you think this is such a case, where the service responses you are lookign for would be difficult to gt from a live test, then using this kind of mocking is appropriate. I know that there are some monitor tests (particularly around alerts) that are very difficult to simulate in live tests.
There was a problem hiding this comment.
@markcowl Recorded Test Session added!
| @@ -6,11 +6,12 @@ | |||
| <PropertyGroup> | |||
| <Description>Microsoft Azure Monitor Library</Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Monitor</AssemblyName> | |||
| <Version>0.25.2-preview</Version> | |||
| <Version>0.25.3-preview</Version> | |||
There was a problem hiding this comment.
Are we ever going to get to 1.0? Just asking. There are large blockers to many customers using pre-release SDKs
There was a problem hiding this comment.
Not sure who it's the appropriate person to answer this.
In the case of DataCollectionRules, it's a feature of a larger product (Azure Monitor)
markcowl
added
the
needs-author-feedback
markcowl
added
needs-review
and removed
needs-author-feedback
* Autorest codeGen; Removing Error*.cs models * Autorest DCR adjust: Set apiVersion to 219-11-01-preview in DCR * DCR & DCRA * Adding DCRA & Testing * Update on csproj & RP.props file * Update monitor_resource-manager.txt & SdkInfo changes * Fix Creadential in DCR & DCRA service operation API; Add Recorded Session Test
[Monitor] Added DataCollectionRules in 2019-11-01-preview