Move configuration-based client logic to Microsoft.Azure.WebJobs.Extensions.Clients #15804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
requested review from
amishra-dev,
amnguye,
seanmcc-msft and
tg-msft
as code owners
ghost
added
the
kasobol-msft
reviewed
Oct 8, 2020
...age/Azure.Storage.Webjobs.Extensions.Blobs/src/Azure.WebJobs.Extensions.Storage.Blobs.csproj
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Webjobs.Extensions.Common/src/Shared/Constants.cs
Show resolved
Hide resolved
| @@ -33,7 +33,7 @@ public static class StorageQueuesWebJobsBuilderExtensions | |||
| /// <returns></returns> | |||
| public static IWebJobsBuilder AddAzureStorageQueues(this IWebJobsBuilder builder, Action<QueuesOptions> configureQueues = null) | |||
| { | |||
| builder.Services.AddAzureClients(_ => { }); | |||
| builder.Services.AddAzureClientsCore(); | |||
There was a problem hiding this comment.
I guess similar change is due in blobs part.
|
/azp where |
Unrecognized OpenAPI bot command (where). |
|
Azure DevOps orgs getting events for this repository: |
suhas92
pushed a commit
to suhas92/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the idea that
Microsoft.Extensions.Azurewould be able to handle all logic of client creation by only knowing the connection name and having IConfiguration instance failed and we moved to it providing helpers to create client "components" viaAzureComponentFactoryI'm removing the feature fromMicrosoft.Extensions.Azure