Only check the touched markdown files in PR for the Verify link step #15929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
This was referenced Oct 13, 2020
Merged
This was referenced Oct 15, 2020
Only check the touched markdown files in PR for the Verify link step
Azure/azure-sdk-for-android#405
Closed
Closed
Closed
Closed
weshaggard
approved these changes
Oct 15, 2020
pakrym
reviewed
Oct 16, 2020
| - template: /eng/common/pipelines/templates/steps/verify-links.yml | ||
| parameters: | ||
| Directory: '' | ||
| Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- '*.md') |
There was a problem hiding this comment.
Can't we encapsulate this logic inside /eng/common/pipelines/templates/steps/verify-links.yml ?
There was a problem hiding this comment.
We currently don't want to update all lang repo. Some languages repos do not have aggregate-report pipeline setup. So it is less the ability of scanning the entire repo. We only update 4 major langs for now. Once we want to update to all repo, we will move the logic inside of verify-links.yml
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: https://dev.azure.com/azure-sdk/public/_build/results?buildId=572769&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2c4000de-e41e-51f5-d969-886b675842ec
Java: Azure/azure-sdk-for-java#16008
.NET: #15929
Python: Azure/azure-sdk-for-python#14466
JS: Azure/azure-sdk-for-js#11803
Android: Azure/azure-sdk-for-android#405
C: Azure/azure-sdk-for-c#1431
CPP: Azure/azure-sdk-for-cpp#787
Go: Azure/azure-sdk-for-go#12809
IOS: Azure/azure-sdk-for-ios#488