Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Monitor Exporter - Minor tweaks and test coverage #16036

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Azure Monitor Exporter - Minor tweaks and test coverage #16036

merged 5 commits into from
Oct 16, 2020

Conversation

rajkumar-rangaraj
Copy link
Contributor

  • Added tests for existing functionality

reyang
reyang approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rajkumar-rangaraj rajkumar-rangaraj merged commit b3b8879 into Azure:master Oct 16, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@rajkumar-rangaraj @annelo-msft
Azure Monitor Exporter - Minor tweaks and test coverage (Azure#16036)
14850dc 
* Added test

* New tests

* Changed activitysource name

* Add TODO

* PR feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas

@TimothyMothra TimothyMothra Awaiting requested review from TimothyMothra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajkumar-rangaraj @reyang