Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable InheritDoc #17259

Merged
merged 7 commits into from
Dec 4, 2020
Merged

re-enable InheritDoc #17259

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65c99c3
equality operators and I*Collection{T}
christothes Dec 3, 2020
3fb32f1
enable inheritdoc
christothes Dec 3, 2020
8e52ded
fix invalid crefs
christothes Dec 3, 2020
a1c149d
Merge remote-tracking branch 'upstream/master' into users/chriss/inhe…
christothes Dec 4, 2020
f5c8942
fix summary closing tags
christothes Dec 4, 2020
c09ea5e
more comment tweaks
christothes Dec 4, 2020
315dc9d
more summary fixes
christothes Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Directory.Build.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<GenerateAPIListing Condition="'$(IsShippingClientLibrary)' == 'true'">true</GenerateAPIListing>
<UpdateSourceOnBuild Condition="'$(UpdateSourceOnBuild)' == ''">$(AZURE_DEV_UPDATESOURCESONBUILD)</UpdateSourceOnBuild>
<PowerShellExe Condition="'$(PowerShellExe)' == ''">pwsh</PowerShellExe>
<InheritDocEnabled>false</InheritDocEnabled>
<InheritDocEnabled>true</InheritDocEnabled>
</PropertyGroup>

<PropertyGroup Condition="'$(IsShippingClientLibrary)' == 'true' and '$(TF_BUILD)' == 'true'">
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/Azure.Core.Amqp/src/AmqpAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ public bool Equals(AmqpAddress other) =>
public bool Equals(string other) =>
_address == other;

/// <inheritdoc/>
/// <summary>Compares two cref="AmqpAddress" values for equality<summary/>
christothes marked this conversation as resolved.
Show resolved Hide resolved
public static bool operator ==(AmqpAddress left, AmqpAddress right)
{
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="AmqpAddress" values for inequality<summary/>
public static bool operator !=(AmqpAddress left, AmqpAddress right)
{
return !(left == right);
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/Azure.Core.Amqp/src/AmqpMessageId.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,13 @@ public bool Equals(AmqpMessageId other) =>
public bool Equals(string other) =>
_messageIdString == other;

/// <inheritdoc/>
/// <summary>Compares two cref="AmqpMessageId" values for equality<summary/>
public static bool operator ==(AmqpMessageId left, AmqpMessageId right)
{
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="AmqpMessageId" values for inequality<summary/>
public static bool operator !=(AmqpMessageId left, AmqpMessageId right)
{
return !(left == right);
Expand Down
12 changes: 6 additions & 6 deletions sdk/search/Azure.Search.Documents/src/SearchDocument/SearchDocument.Dictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public bool TryGetValue(string key, out object value) =>
/// <inheritdoc />
public ICollection<string> Keys => _values.Keys;

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.Values" />
ICollection<object> IDictionary<string, object>.Values => _values.Values;

/// <inheritdoc />
public int Count => _values.Count;

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.IsReadOnly" />
bool ICollection<KeyValuePair<string, object>>.IsReadOnly => _values.IsReadOnly;

/// <inheritdoc />
Expand All @@ -47,15 +47,15 @@ public bool TryGetValue(string key, out object value) =>
/// <inheritdoc />
public bool ContainsKey(string key) => _values.ContainsKey(key);

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.Add" />
void ICollection<KeyValuePair<string, object>>.Add(KeyValuePair<string, object> item) =>
SetValue(item.Key, item.Value);

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.Contains" />
bool ICollection<KeyValuePair<string, object>>.Contains(KeyValuePair<string, object> item) =>
_values.Contains(item);

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.CopyTo" />
void ICollection<KeyValuePair<string, object>>.CopyTo(KeyValuePair<string, object>[] array, int arrayIndex) =>
_values.CopyTo(array, arrayIndex);

Expand All @@ -69,7 +69,7 @@ public IEnumerator<KeyValuePair<string, object>> GetEnumerator() =>
/// <inheritdoc />
public bool Remove(string key) => _values.Remove(key);

/// <inheritdoc />
/// <inheritdoc cref="ICollection{T}.Remove" />
bool ICollection<KeyValuePair<string, object>>.Remove(KeyValuePair<string, object> item) =>
_values.Remove(item);

Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/Rules/CorrelationRuleFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ public override bool Equals(RuleFilter other)
return false;
}

/// <inheritdoc/>
/// <summary>Compares two cref="CorrelationRuleFilter" values for equality<summary/>
public static bool operator ==(CorrelationRuleFilter left, CorrelationRuleFilter right)
{
if (ReferenceEquals(left, right))
Expand All @@ -281,7 +281,7 @@ public override bool Equals(RuleFilter other)
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="CorrelationRuleFilter" values for inequality<summary/>
public static bool operator !=(CorrelationRuleFilter left, CorrelationRuleFilter right)
{
return !(left == right);
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/Rules/CreateRuleOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public bool Equals(CreateRuleOptions other)
return false;
}

/// <inheritdoc/>
/// <summary>Compares two cref="CreateRuleOptions" values for equality<summary/>
public static bool operator ==(CreateRuleOptions left, CreateRuleOptions right)
{
if (ReferenceEquals(left, right))
Expand All @@ -146,7 +146,7 @@ public bool Equals(CreateRuleOptions other)
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="CreateRuleOptions" values for inequality<summary/>
public static bool operator !=(CreateRuleOptions left, CreateRuleOptions right)
{
return !(left == right);
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/Rules/FalseRuleFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public override bool Equals(RuleFilter other)
return other is FalseRuleFilter;
}

/// <inheritdoc/>
/// <summary>Compares two cref="FalseRuleFilter" values for equality<summary/>
public static bool operator ==(FalseRuleFilter left, FalseRuleFilter right)
{
if (ReferenceEquals(left, right))
Expand All @@ -62,7 +62,7 @@ public override bool Equals(RuleFilter other)
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="FalseRuleFilter" values for inequality<summary/>
public static bool operator !=(FalseRuleFilter left, FalseRuleFilter right)
{
return !(left == right);
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/Rules/SqlRuleFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public override bool Equals(RuleFilter other)
return false;
}

/// <inheritdoc/>
/// <summary>Compares two cref="SqlRuleFilter" values for equality<summary/>
public static bool operator ==(SqlRuleFilter left, SqlRuleFilter right)
{
if (ReferenceEquals(left, right))
Expand All @@ -121,7 +121,7 @@ public override bool Equals(RuleFilter other)
return left.Equals(right);
}

/// <inheritdoc/>
/// <summary>Compares two cref="SqlRuleFilter" values for inequality<summary/>
public static bool operator !=(SqlRuleFilter left, SqlRuleFilter right)
{
return !(left == right);
Expand Down