Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install NET5 #17281

Merged
2 commits merged into from
Jan 4, 2021
Merged

Don't install NET5 #17281

2 commits merged into from
Jan 4, 2021

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Dec 2, 2020

Fixes: #17118

.NET 5 is available, by default, on all agents now.

I'll keep the file so we don't have to re-discover all the places we need to install dotnet the next time.

@pakrym pakrym closed this Dec 9, 2020
@pakrym pakrym reopened this Dec 9, 2020
@pakrym
Copy link
Contributor Author

pakrym commented Dec 9, 2020

/azp run net - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

inputs:
packageType: runtime
version: "2.1.x"
steps: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @mitchdenny

@pakrym we should at least add a comment here. We might even want to consider adding a verification step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately, the installation step was fast and non-flaky. Should we keep it instead of the verification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I would do this is comment the tasks out with a brief comment at the top explaining that they can be commented back in when a new version of .NET is released and the hosted agents don't yet have the bits. I think this is something we'll oscillate on a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments/kept commented out steps.

@ghost
Copy link

ghost commented Jan 4, 2021

Hello @pakrym!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d744401 into Azure:master Jan 4, 2021
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Fixes: Azure#17118

.NET 5 is available, by default, on all agents now.

I'll keep the file so we don't have to re-discover all the places we need to install dotnet the next time.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove an explicit UseDotNet step when .NET 5 would be available on Devops machines
3 participants