-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install NET5 #17281
Don't install NET5 #17281
Conversation
/azp run net - core - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
inputs: | ||
packageType: runtime | ||
version: "2.1.x" | ||
steps: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: @mitchdenny
@pakrym we should at least add a comment here. We might even want to consider adding a verification step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lately, the installation step was fast and non-flaky. Should we keep it instead of the verification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I would do this is comment the tasks out with a brief comment at the top explaining that they can be commented back in when a new version of .NET is released and the hosted agents don't yet have the bits. I think this is something we'll oscillate on a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments/kept commented out steps.
Hello @pakrym! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes: Azure#17118 .NET 5 is available, by default, on all agents now. I'll keep the file so we don't have to re-discover all the places we need to install dotnet the next time.
Fixes: #17118
.NET 5 is available, by default, on all agents now.
I'll keep the file so we don't have to re-discover all the places we need to install dotnet the next time.