Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text Analytics] Expose StringIndextype for all endpoints #17968

Merged
merged 15 commits into from
Jan 16, 2021
Merged

[Text Analytics] Expose StringIndextype for all endpoints #17968

merged 15 commits into from
Jan 16, 2021

Conversation

suhas92
Copy link
Member

@suhas92 suhas92 commented Jan 14, 2021 •
edited
Loading

Description

This PR exposes StringIndexType for all endpoints.

For AnalyzeOperation, the StringIndexType will be passed from the parameters in the Tasks collection

suhas92
suhas92 commented Jan 14, 2021
View reviewed changes
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsRequestOptions.cs
@@ -40,5 +42,10 @@ internal TextAnalyticsRequestOptions(bool includeStatistics, string modelVersion
/// <a href="https://docs.microsoft.com/azure/cognitive-services/text-analytics/how-tos/text-analytics-how-to-sentiment-analysis#model-versioning"/>.
/// </summary>
public string ModelVersion { get; set; }

/// <summary>
/// StringIndexType
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this.

maririos
maririos reviewed Jan 14, 2021
View reviewed changes
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsRequestOptions.cs Outdated Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsRequestOptions.cs Outdated
/// <summary>
/// StringIndexType
/// </summary>
public StringIndexType? StringIndexType { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to keep a default value for the library, so user doesn't have to think about it.
I think it will be clearer for the user if they can see the default value of this parameter here.
Because it will always have a value, make it non-nullable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to work on the name (it could be in another PR) as currently it is hard to understand what it means

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could u open an issue for addressing the name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u put the link here so we can have the reference?

sdk/textanalytics/Azure.AI.TextAnalytics/tests/AnalyzeSentimentTests.cs Outdated Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/AnalyzeSentimentTests.cs Outdated Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsClient.cs Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsClient.cs Show resolved Hide resolved
maririos
maririos reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized, because of this addition, we are going to have to surface the property Length again in every type where it applies. Could you create an issue for it so later we can add it?

sdk/textanalytics/Azure.AI.TextAnalytics/tests/TextAnalyticsClientLiveTests.cs Outdated Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/TextAnalyticsClientLiveTests.cs Outdated Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/TextAnalyticsClientLiveTests.cs Show resolved Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/PiiTaskParameters.cs Outdated Show resolved Hide resolved
...ty/Azure.MixedReality.Authentication/api/Azure.MixedReality.Authentication.netstandard2.0.cs Outdated Show resolved Hide resolved
@suhas92 suhas92 mentioned this pull request Jan 15, 2021
Closed
@suhas92
Copy link
Member Author

suhas92 commented Jan 15, 2021

Just realized, because of this addition, we are going to have to surface the property Length again in every type where it applies. Could you create an issue for it so later we can add it?

#18018

@maririos maririos merged commit a99c3e0 into Azure:master Jan 16, 2021
@maririos maririos mentioned this pull request Jan 20, 2021
Closed
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
@suhas92
[Text Analytics] Expose StringIndextype for all endpoints (Azure#17968)
f113af2 
Expose stringindextype to all endpoints
@maririos maririos mentioned this pull request Feb 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees
No one assigned
Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suhas92 @maririos