Extending TokenRequestContext to accept additional Claims #18236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
requested review from
chidozieononiwu,
danieljurek,
KrzysztofCwalina,
mitchdenny,
pakrym,
tg-msft and
weshaggard
as code owners
ghost
added
the
pakrym
reviewed
Jan 27, 2021
| @@ -417,6 +417,8 @@ public abstract partial class TokenCredential | |||
| private readonly object _dummy; | |||
| private readonly int _dummyPrimitive; | |||
| public TokenRequestContext(string[] scopes, string? parentRequestId = null) { throw null; } | |||
| public TokenRequestContext(string[] scopes, string? parentRequestId = null, string? claims = null) { throw null; } | |||
| public string? Claims { get { throw null; } } | |||
There was a problem hiding this comment.
"Claims" is plural but not a collection while Scopes is. Why?
There was a problem hiding this comment.
The value of this property actually corresponds to the claims parameter in OpenID, a complex json object containing a collection of claims which need to be included in the issued token (I will add more detail on this to the xml comments). Given that do you still have an issue with the property name being plural?
There was a problem hiding this comment.
Hm, does it follow some spec?
There was a problem hiding this comment.
https://openid.net/specs/openid-connect-core-1_0-final.html#ClaimsParameter, I can link to this directly in the doc comments.
KrzysztofCwalina
approved these changes
Jan 27, 2021
christothes
approved these changes
Jan 29, 2021
jongio
pushed a commit
to jongio/azure-sdk-for-net
that referenced
this pull request
Feb 9, 2021
* Extending TokenRequestContext to accept additional Claims * updating api definitions * fix ctor ambiguity
markcowl
pushed a commit
that referenced
this pull request
Feb 12, 2021
* [Service Bus Cient] Client Mockability Fix (#18254) The focus of these changes is to virtualize read-only properties that cannot be set as part of the constructor to enable mocking them during testing. * Adjust build warning settings * Sync eng/common directory with azure-sdk-tools repository (#18282) * Enable testing of public_exponent against MHSM (#18283) Resolves #16789 * Add CreateEcKeyOptions class (#18272) Resolves #16853 * Log more information for canceled CertificationOperations (#18289) Relates to #17718 * EG API updates (#18274) * EG API updates * webjob tests * Use optional serializer param in GetData<T> methods; revert culture in SAS * Additional operations and test cases for Azure Quantum SDK (#18239) Co-authored-by: Victor XField <vxfield@outlook.com> * Add SyncAsyncEventHandler (#18170) * Add support for create, update, and delete for custom role definitions (#18227) * Implement create, update, get, and delete for Role Definitions * [FR] Modify `Pages` type (#18260) Changed the type for `IEnumerable` to `IList` as this is a property in an input-only object. Followed what other libraries like Search and KV do. * Quota API GA version SDK updates. (#17965) * Updates for GA version - <AzureApiTag>Capacity_2020-10-01-preview;Capacity_2020-10-25;</AzureApiTag> * Updating release notes. * Updating version to -Preview - 1.15.0-preview * Updated Package release notes. * Removing -Preview from changelog.md to fix CI build error. * Adding -Preview to Package version. * Updating recorded Tests. * Updating Tests. * Uprating the version to - <Version>1.15.0-preview</Version> in csproj file. * Updating Tests. * Updating commit ID. * Removing model files not nrequired. * Move global variable to the pipeline level (#18288) To ensure we always include the global variables in all our pipeline jobs and stages we should import the variables at the highest pipeline level to ensure we don't miss setting these variables in any jobs. * Sync eng/common directory with azure-sdk-tools for PR 1345 (#18287) * Enforce API approval status for GA and include SDK type in package properties * Fix per review comment * Fixes as per review comments to avoid changing constructor signature * Fixes as per review comments to handle track 1 packages * Fix yaml format error Co-authored-by: praveenkuttappan <prmarott@microsoft.com> * Initial commit * Temporarily re-enable .NET 5 SDK install step (#18298) * Fix Waqar's comment. * [Storage] Queues - Failed message handler (#17001) In this PR: - Ability to provide a handler to capture queue messages that are in invalid format. Bonus: - Ability to get parent queue service (like we did in #16437 ) Pending dependency: #18170 * [FR] Language and Locale as extensible enums (#18271) * language and locale as extensible enums * Import global variables all mgmt jobs * [Identity] Preparing for Azure.Identity 1.4.0-beta.2 release (#18281) * upgrading msal dependency * update changelog * updating test recordings * Ignore sample tests (#18292) The sample tests weren't intended to be run in the CI, but were instead useful to demonstrate how you might perform the different methods of authentication. That's actually done in the README now, so i'm just going to remove it since I can't make the build happy with keeping them around. * Increment version for identity releases (#18301) Increment package version after release of Azure.Identity * Updated with success cases. * 1ES pools update for release pipeline. (#18267) * Sync eng/common directory with azure-sdk-tools for PR 1351 (#18314) * tweaks to New-TestResources readme * [EngSys] Fixing CODEOWNERS Typo (#18316) The focus of these changes is to fix a typo in label application for the Digital Twins service. The ownership of Service Bus has also been tweaked to reflect a change in areas of responsibility. * Update AutoRest C# version (#18249) Co-authored-by: Shivangi Reja <shreja@microsoft.com> * acr: update change log for releasing (#18303) * Update the readme with more information about thread safety and other… (#18290) * Update the readme with more information about thread safety and other concepts. * Update sdk/keyvault/Azure.Security.KeyVault.Administration/README.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> * Update sdk/keyvault/Azure.Security.KeyVault.Administration/README.md Co-authored-by: Heath Stewart <heaths@outlook.com> * Address PR feedback. Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Heath Stewart <heaths@outlook.com> * Made Storage Client CanGenerateSasUri properties mockable (#18277) * Add APIView KV variable group to prepare pipeline (#18304) * Adding more test cases for Azure Quantum Mgmt SDK (#18247) * Improve Az Login logic for recording auth * Adding remaining test cases * Update webjobs queue extension CHANGELOG.md for base64 (#18325) Provided a sample host.json to make it easier for functions uses to take advantage of the ability to opt-out of base64 encoding. * Update samples (#18293) * [MetricsAdvisor] Fixing failing test (#18321) * Azure Quantum SDK Readme (#18296) Authored-by: matusthemostlygreat <77749405+matusthemostlygreat@users.noreply.github.com> * Verify API status check changes (#18176) Draft PR to verify common changes. * Update CHANGELOG.md (#18333) * Fix sample (#18332) * Fix sample * Fix * Update AutoRest C# version (#18331) * Regenerate baseline because last one break. (#18270) * Updating CODEOWMNERS entry for Azure.Identity (#18336) * fix (#18327) * Fix DateTime bug (#18340) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * [Communciation] - Remove nullable reftypes from the public surface of the Identity and Common package (#18334) * Revert "Temporarily re-enable .NET 5 SDK install step (#18298)" (#18324) This reverts commit 21ebca7. * Base64 encoding remarks. (#18345) * Document that DeletedSecret.Value is always null (#18300) Resolves #17741 To note, I also checked if/how this applies to DeletedKey and DeletedCertificate. When retrieved individually, the public key portion of the JWK is retrieved and both the SecretId and KeyId on DeletedCertificate are present as well. * Update IE E2E. * Normalize the package name for Doc.Ms readme (#18262) * Sync eng/common directory with azure-sdk-tools for PR 1353 (#18348) * Use a helper function to normalize the package name for readme * Get the readme name from artifact-metadata-parsing * Change to the readme * Update eng/common/scripts/artifact-metadata-parsing.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * [MetricsAdvisor] Made constructor of DataFeed parameterless (#18319) * Fixed bug when setting Viewers and Administrators during Data Feed creation. * Made DataFeed-related collections not settable. * [TA] Healthcare Design update (#18200) * [Storage] Badly encoded handler in Webjobs (#18326) * wip * export api. * that works. * handle peeked messages * api * post merge. * propagate queueclient. * fire and forget callback. * tweaks. * re-record. * hack core temporarily. * use event hander from core. * revert test change. * remove direct core reference from test package. * that won't be necessary. * more tests. * readme. * whitespace. * change options creation. * some pr feedback. * api * get parent queue service. * can handle bad message. * blob trigger. * post-merge. * post-merge. * Increment version for quantum releases (#18337) Increment package version after release of Azure.Quantum.Jobs * fix typo (#18335) * Extending TokenRequestContext to accept additional Claims (#18236) * Extending TokenRequestContext to accept additional Claims * updating api definitions * fix ctor ambiguity * [Event Hubs Client] Formatting Pass (#18356) The purpose of these changes is to format code to apply project conventions for consistency and in some cases, update member names and documentation to better convey context. **Note:** These changes are intended to be superficial; no change to existing behavior should have taken place. * Remove IDisposable from TokenCache (#18346) * Remove IDisposable from TokenCache * Remove unused autores.md file (#18294) * Remove unused autores.md file * Update generate.ps1 * Generate 2020-03-01 2020-07-01-preview policy operations (#18194) * Generate 2020-03-01 2020-07-01-preview policy op * generated policy 2020-09-01 * [Storage] Webjobs extension sample apps. (#18358) * nest sample tests? * queues sample app. * nesting. * new link. * blobs sample. * fix build. * fix build. * does this fix the build ? * Mixed Reality Authentication: Updated the MR STS spec file (#18341) This change updated the library to consume the latest version of spec file, which changes the account identifier to be a `Guid` rather than a `string`. The service expects a `Guid` or `UUID`, so it makes sense to be specific. * Refactor TestEnvVar (#18364) Improve `TestEnvVar` to handle consistent cleaning and stashing of existing environment variables. * Adding PR template for net repo (#18357) * Adding PR template * CR feedback * EG API Updates (#18369) * Update API based on review feedback * Update samples * fix * Update wording * Fix sample * CloudServices 43-preview release update (#18372) * hopefully fixed live tests (#18376) * Remove nullable refs sms (#18370) * Remove nullable ref-types from sms sdk * Code review changes - add a basic constructor (with connection string only) for sms client * code review changes * fix for build check failures * Bringing the feature branch for chat API version 2020-11-01-preview3 to master (#18388) Co-authored-by: Camilo Ramirez <juramir@microsoft.com> * [DataFactory]Merge new features into master (#18380) * Sync eng/common directory with azure-sdk-tools for PR 1364 (#18394) * Support sub directory for artifact location * Fix as per review comment to avoid artifact sub path * Package property file is not created for track1 and management pacakges. * Fix property name case * Fix as per review comments * Fix as per review comments * Use Config File param value as is * Change to make path joineasily readable Co-authored-by: praveenkuttappan <prmarott@microsoft.com> * [Core.Experimental] Add DynamicContent/DynamicRequest/DynamicResponse for LLC prototype (#18323) - Originally from https://github.com/ellismg/AnomalyDetectorLowLevelClient/ * Sync eng/common directory with azure-sdk-tools for PR 1365 (#18396) * Updated cosmos emulator yml script to remove the existing installation, install latest version and run emulator with latest version * Added default emulator start arguments if none provided * Updated default start params * Updated default start params in PS script * Updated default start params in PS script Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com> * [Communication] - Simplify identifier json models (#18389) * [Communication] - Simplify identifier json models * Add validation for multiple properties being present * [Event Hubs Client] Move Blob Checkpoint Store to Shared (#18395) The focus of these changes is to complete migration of the Blobs Checkpoint Store from the `Azure.Messaging.EventHubs.Processor` project to the `Azure.Messaging.EventHubs.Shared` project. To facilitate sharing the checkpoint store between the processor and the Functions extensions, the implementation for the store was moved into the shared project, though its tests remained in the processor. In order to follow the pattern of keeping locality between shared code items and their tests, the checkpoint store tests, both unit and live, have been migrated to the shared testing project. In support of this, some of the live testing infrastructure specific to managing storage resources has also been migrated into the shared project as part of the `BlobTesting` category of shared items. Some refactoring and reformatting of the storge tests has also been performed to improve consistency with other Event Hubs code, trim dead areas, and improve readability. * Delete CloudService tests from the stable release (#18390) * Delete CloudServiceExtensionTests.cs * Delete CloudServiceOperationTests.cs * Delete CloudServiceRoleInstanceTests.cs * Delete CloudServiceScenarioTests.cs * Delete CloudServiceTestsBase.cs * Delete CloudServiceUpdateTests.cs * Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole.json * Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole_MultiRoleExtension.json * Delete Test_Create_PowerOff_Start_CloudServiceOperation.json * Delete Test_ListCloudServicesOperation.json * Delete Test_CloudServiceRoleInstanceOperations.json * Delete TestCloudServiceScenarioOperations.json * Delete TestCloudServiceScenarioOperations_DeleteCloudService.json * Delete TestCloudServiceScenarioOperations_ExtensionProfile.json * Delete TestCloudServiceScenarioOperations_InstanceView.json * Delete TestCloudServiceOperations_ScaleIn_ScaleOut.json * Delete TestCloudServiceUpdateOperations.json * Update AzSdk.RP.props * Update AzSdk.RP.props remove containerService * Delete ServiceConfigurationHelpers.cs * ADT: Fix the issue with non-default object serializers in Query APIs (#18379) * Fix the bug with non-default ObjectSerializer in QueryClient * [Communication] - Follow standards for identity client options version (#18400) * [TA] PageableOperation implementation (#18351) * Sync eng/common directory with azure-sdk-tools for PR 1366 (#18398) * Scan all duplicate artifacts which set hide to true * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * [Event Hubs Client] Producer Dead Code Removal (#18424) The focus of these changes is to trim the dead code paths for publishing a single event from the producer client and assocaited tests. This overload existed in early pre-GA betas but has been determined to be unlikely to return to the public API in the future. * Bump digital twins version for 20201-02-03 (#18403) * Update xml documentation for TokenRequestContext.Claims (#18367) * Update xml documentation for TokenRequestContext.Claims * fix cref to href * Increment version for digitaltwins releases (#18430) Increment package version after release of Azure.DigitalTwins.Core * uncomment readme links. (#18429) * [MetricsAdvisor] Made constructor of AnomalyDetectionConfiguration parameterless (#18393) * Update PR with inbound endpoint changes. * renames, modify types, test cleanup (#18421) * Use Utf8JsonWriter to write JsonElement to stream instead of using th… (#18436) * bump webjobs. (#18428) * Remove extra dependency (#18438) * Update AutoRest C# version (#18338) * Implement BearerTokenChallengeAuthenticationPolicy (#18368) Handles bearer token authorization challenges and is extensible for sub-class implementers. closes #15650 * [IoTCentral] resourceType became camel case, added industry, locations field to appTemplate API, added origin, properties field to operations API (#18415) * include camel case, apptemplateName changes * add industry and locations to appTemplate api * update unit test * [TA] Implement Pageable actions (#18371) * Migrate SB extensions to new SDK (#18330) * Migrate SB extensions to new SDK * Fixes * API * Remove ExceptionHandler API * PR fb * Fix test * add back cleanupentity * Update SyncAsyncEventArgs APIs (#18437) * [Event Hubs Client] Storage Implementation Feedback (#18439) The focus of these changes is to consider feedback provided by an internal review of the blob storage manager by one of the developers responsible for the Azure Blob Storage client library. Many of the larger and more critical items have already been used for adjustments; these tweaks address the majority of the remaining minor items. * Add default constructor to CertificatePolicy for import (#18443) Resolves #16217 * Generate CDN SDK for 2020-09-01 AFDX support (#18218) * Generate 2020-09 version code * add cdn_resource-manager.txt, update ApiVersion modifier * update passed records * update test record, fix failed case * Add AFDX source test and records * Update test Records, Update test utilities * Add secret test and records * Update with swagger * Update with new swagger * Use latest swagger * Add test case and records * Update test cases and records * Update the package version Co-authored-by: Chenglong Liu <chengll@microsoft.com> * Code style and syntax clean up (#18445) * Code style and syntax clean up * regenrate the code. Co-authored-by: Azad Abbasi <azabbasi@microsoft.com> * Revert "[TestFramework] Downgrade Azure.Identity for maximum compat (#18153)" (#18450) - Azure.Identity 1.0.0 does not work on sovereign cloud which is required for our functional tests - Reverting until we can find a better solution for both perf and functional tests - This reverts commit 0f409d2. * Merge always updates for batch operations (#18446) * Mixed Reality Authentication: This change builds and tests the shared code (#18397) This change does the following: - Added a new Share.Azure.MixedReality.Authentication.Tests project to test the shared code. I did find 1 bug that presented when compiling with .NET 5.0 due to better nullable annotations. I had to pull the shared code in as source because I couldn't get `InternalsVisisbleTo` to work in this repo. - This change adds a project file to build the Mixed Reality Authentication shared code to ensure it stays healthy. - It took a while to figure out how to add a project that wasn't going to be packaged and shipped, but could also access shared code and what not. You'll see me defining the `AzureCoreSharedSources` property manually because that property is only set for official client libraries which have certain criteria like starting with "Azure.". * Add support for MSI credential in configuration (#18459) * selection marks allows null (#18452) * [Synapse] - General Available Release (#18252) * Generate code for 2020-12-01 * [Synapse] - General available release * Update AzSdk.RP.props Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Changes to refer new API version of Resource Mover Service (#18432) * Resource Mover generated code for new version. * Added tests. * Re ran generated.ps1 * Updates. * Updated AzSDK.props Co-authored-by: Ajay Gupta <ajgupt@microsoft.com> * Update with refactoring. * Update with minor comments. * Update yml file * [MetricsAdvisor] Made AnomalyAlertConfiguration constructor parameterless (#18458) * [Storage] Webjobs update metapackage Changelog. (#18456) * [Synapse] Update swagger to aa19725fe79aea2a9dc580f3c66f77f89cc34563, bump to newest AccessControl API, add new Artifacts.Library API (#18343) - There is work here porting the existing AccessControl tests to the new API but I've also [Ignore]'ed the test. - The new API won't allow ID reuse for a month, and that's playing havoc w\ the recording system so far. * [synapse] Remove Library API for now from public API (#18481) * [Service Bus Client] Doc Comment Reformatting Test (#18485) The focus of these changes is to reformat the doc comments in a file that has been rendering incorrectly for the MS Docs site to test the theory that the indentation of the XML is influencing MS Docs formatting. * [Communication] - Ensure RestClients are created based on ClientOptions.ApiVersion (#18464) * Prepare for SB release (#18486) * Prepare for SB release * Update version * Remove <inheritdoc> from customized models to fix project warnings (#18484) * [MetricsAdvisor] Made NotificationHook constructors parameterless (#18475) * Updated jsom files. * Print assembly informational version (#18490) * [Core.Experimental] Improvements for Protocol Clients (#18412) [Core.Experimental] Improvements for Protocol Clients - Add a ProtocolClientOptions type for use by clients which have no additional options. This means we don't have to generate a type per client - Add a zero argument constructor to `DynamicJson` that behaves like DynamicJson.Object(), since we expect that `DynamicJson` will appear in API signatures and users will want to be able to `new` up the type. * Update AutoRest C# version to 3.0.0-beta.20210205.2 (#18460) * Azure Monitor Exporter: rename (#18494) * first pass on rename. compile successful * cleanup * Get ready for Azure.Core 1.9.0 (#18453) * Take reference on new TokenRequestContext (#18440) * Added a client consumption example (#18463) - In the board review, they requested that we add an example of how someone would consume the `AccessToken` in a client. No clients exist today, so we're keeping things hypothetical for now to make the point. * Define custom platform for HSM tests (#17925) Resolves #16483 * Increment package version after release of Azure.Core (#18502) * Downgrading Microsoft.Identity.Client dependency to 4.23 (#18492) We have been asked by a partner team to downgrade to Microsoft.Identity.Client 4.23 for our next beta release to align with their dependencies to avoid a resetting test coverage. We will again upgrade to the latest Microsoft.Identity.Client before the GA release of 1.4.0. * Ensure only a single action for a document is added to a batch (#18469) * Ensure only a single action for a document is added to a batch * Add test to validate batch splitting behavior * Add a test to verify case-sensitive nature of keys * Add Data Plane SDK for Azure Remote Rendering (#18159) This adds the .net SDK for Azure Remote Rendering. Tests are included which convert assets, start a session and confirm a number of failure cases behave correctly. * Rename a few properties in SearchIndexingBufferedSenderOptions (#18285) * Rename a few properties in SearchIndexingBufferedSenderOptions * Update samples and API using scripts * Update Batching.Publisher.BatchActionCount when handling a 413 * AppAuth 1.6.1 release (#18478) * Add the Remote Rendering package to the CI pipeline (#18523) When adding ARR, I missed the pipeline step which generates the package. * Remove flaky tests and increase CLI timeout (#18500) * Remove flaky tests and increase CLI timeout * Update nuget version in README.md (#18473) * Update nuget version in README.md * Addressing review comments + clean up for preview 3 release + update release date. Co-authored-by: Camilo Ramirez <juramir@microsoft.com> * Update three pass services to enable live testing in sovereign clouds for multiple services (#18162) * change core,extension and search * remove core change * resolve ci error * expose length again (#18505) * Connection options fix (#18508) * Pass options to consumer client * fix * Update Azure.Core to 1.9.0 (#18538) * Prepare for Azure.Core.Experimental beta.8 release (#18537) * Prepare for release (#18514) * Prepare for release * Update changelog * Disable OS verification (#18518) * Disable OS verification * Update devops helper script based on changes in azure-sdk repo (#18540) - Sync devops helper script changes - Fix issue in SemVer script when using strict mode with Language not set Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Log Key Vault Certificates content for live tests (#18558) Needed to diagnose a test failure where the operation is completed, but the status is still "inProgress". * [Text Analytics] Analyze design update (#18406) * Increment version for core releases (#18561) Increment package version after release of Azure.Core.Experimental * Update Azure.Core.Experimental to beta.8 (#18559) * Increment version for extensions releases (#18572) * [MetricsAdvisor] Made MetricFeedback class abstract (#18511) * Add sovereign cloud opt-in to tests weekly (#18488) * [Perf] [Stress] Add netcoreapp3.1, enable Server GC on net461 (#18577) * Also enable Server GC by default in stress projects * [Storage] Point to latest core. (#18581) * [MetricsAdvisor] Removed setters from collections (#18493) * Updating Backup SDK to 2021-01-01 (#18310) * Added generated changes for 2021-01-01 Backup SDK * Adding release info * Updated Test Cases * Fixing reference generation discrepency error * Using autorest 2.3.82 to generate code * Regenerating SDK based on latest Swagger * Remove search client helper method (#18578) * Remove helper method in SearchClient Callers can instantiate an instance of SearchIndexingBufferedSender in lieu of calling CreateIndexingBufferedSender(). * Update API file * Address PR comment for Inbound Endpoint E2E and added Nrp simulator change. * Fix typo. * [CDN] AFDX Update from latest swagger (#18587) * Update from latest swagger * Update version to 6.1.0 * [Storage] MessageDecodingFailed changelog. (#18585) - forgotten changelog entry. * [Event Hubs] Update Package Dependencies (#18560) The focus of these changes is to update package dependencies for the February release. * [Event Hubs Client] February Release Documentation (#18263) The focus of these changes is updating the samples, README, and change log to reflect the February milestone release. * [synapse] Reenable AccessControlClientLiveTests as LiveOnly. Mark others as RecordedTest (#18499) - Give up on making AccessControlClientLiveTests record-able and mark as LiveOnly - [RecordedTest] seems to be a flatly better [Test] for all RecordedTestBase derived tests, so use it * Increment version for eventhub releases (#18594) Increment package version after release of Azure.Messaging.EventHubs * [Event Hubs Client] Processor Release Prep (#18595) The focus of these changes is to prepare the Event Processor package for the Februrary release. * [Synapse][Artifacts] - Make some models public (#18515) * Make some models public * Fix Export API issue Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * Update Contributing.md for Prepare Release Section (#18441) * Update Contributing.md * Remove eng/scripts/Prepare-Release.ps1 * Increment package version after release of Azure.Messaging.EventHubs.Processor (#18599) * [synapse] Correct version numbers (#18597) - AccessControl should be preview.3 (see https://www.nuget.org/packages/Azure.Analytics.Synapse.AccessControl/) - Artifacts should be preview.6 (since beta.1 should have been .5) (https://www.nuget.org/packages/Azure.Analytics.Synapse.Artifacts/) - Spark should be preview.4 (since beta1 should have been .3) (https://www.nuget.org/packages/Azure.Analytics.Synapse.Spark/) * add release date (#18602) * [synapse] Add release notes for Feb-2021 release (#18604) - Fold the misnamed beta.x releases into the next preview to prevent tool confusion * [TA] Update changelog (#18580) Fixes: #18563 * [synapse] Update release notes with concrete date (#18608) * Add an internal ObjectNotDisposedException (#18605) that we can throw/immediately catch from finalizers when an object wasn't properly disposed and there's pending work being lost or resources being leaked * remove Core proj reference (#18547) * [communication] prep release for common, identity, chat (#18586) * [Messaging Clients] README Updates (#18607) The focus of these changes is to update the README content for the messaging libraries to correct issues flagged during the MS Docs publishing validation. In addition, the Service Bus text detailing C# 8.0 and language versions has been expanded with some additional context. * Resolve archboard feedback (#18582) * Rename Encrypt/DecryptOptions to Encrypt/DecryptParameters * Make AdditionalAuthenticatedData read-only * Change parsing of Key Vault identifiers and implement IEquatable<T> * Remove proj ref to Core (#18619) * [Perf] Prevent divide-by-zero for incomplete threads (#18512) * Increment package version after release of Azure.Messaging.EventGrid (#18620) * Improve the dev feed section (#18462) * Improve the dev feed section * Remove csproj option. Remove multiple feed refs. * Remove csproj file ref * Code formatting * Change aka to full url * Increment version for formrecognizer releases (#18622) Increment package version after release of Azure.AI.FormRecognizer * Update to close pending comments. * [MetricsAdvisor] Updated Create methods to return whole models instead of ID (#18491) * Adding "Thread safety" and "Additional concepts" sections to our client's READMEs (#18354) * [ContainerInstance] added ci.yml file for the pipeline. (#18349) * Update Microsoft.Extensions.Azure to 1.1.0-beta.2 (#18574) * update * refs * Make proj ref and mark as extension library * service bus Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fixing error response for CosmosDB 2020-06-01-preview (#18399) * Fixing error response for CosmosDB 2020-06-01-preview * Updating SDK using merged swagger * Updating generate.ps1 * Fixing assembly version * Removing config file tag * Rerunning with correct version of autorest.csharp * Version 2.3.82 * Rerunning generate.ps1 * Update changelog for release (#18625) * Fixed Github IO to use .NET display name (#18623) * Increment version for identity releases (#18628) Increment package version after release of Azure.Identity * Increment version for communication releases (#18627) * Increment package version after release of Azure.Communication.Identity * Increment package version after release of Azure.Communication.Common * Increment package version after release of Azure.Communication.Chat * Increment version for metricsadvisor releases (#18629) Increment package version after release of Azure.AI.MetricsAdvisor * Updated storage changelogs (#18617) * Prepare Azure.Search.Documents 11.2.0 GA release (#18621) * Prepare Azure.Search.Documents 11.2.0 GA release * Add public changes in the CHANGELOG * Add a line to show inclusion of all beta changes in GA * Increment version for servicebus releases (#18624) Increment package version after release of Azure.Messaging.ServiceBus * Add release date (#18636) * Prepare beta release of Key Vault SDKs (#18635) * Increment version for storage releases (#18637) * Azure Purview dot net SDK (#18237) * Azure Purview dot net SDK * Add Purview to build path * Update code location to make generation file * Add readme * move readme * Update SDK generation file location * Update to add src and test folder * Fix readmes * Update nuget version, address minor pr comments * Changes ExampleId type to long (#18543) * Changes ExampleId type to long * Fixes build errors * Validates skip and take not equal null * retrigger checks Co-authored-by: Younes <v-mayounes@microsoft.com> * Increment version for eventhub releases (#18638) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventHubs * [Azure.Core.Experimental] Package Ref to Core (#18618) The focus of these changes is to shift to a pacakge reference to Azure.Core, allowing the dependency to bind to the latest GA release. * Prepare MR Authentication for pre-release (#18613) This change removes the nullable awareness since that is the current guidance. I've also changed the prerelase tag to match current guidance. * Update CHANGELOG.md (#18658) * Changes from running the release script (#18659) These are changes related to preparing to release the package. * Update AuthenticationRecord and TokenCache Samples (#18639) 1. The `using` declaration is scoped to the method, so the stream was not closed before it needed to be read. Changed to `using(){}` 2. Added line wrapping so devs don't have to horizontal scroll when viewing the samples. I ran `dotnet test Azure.Identity.sln` before pushing and it passed. * Changes from running the release script. (#18661) * Increment version for synapse releases (#18653) * Increment package version after release of Azure.Analytics.Synapse.Spark * Increment package version after release of Azure.Analytics.Synapse.Monitoring * Increment package version after release of Azure.Analytics.Synapse.ManagedPrivateEndpoints * Increment package version after release of Azure.Analytics.Synapse.Artifacts * Increment package version after release of Azure.Analytics.Synapse.AccessControl * Updated to namespace. * Update Azure.Core.Experimental to beta.9 (#18664) * Add SecretReferenceConfigurationSetting, FeatureFlagConfigurationSetting and AddSyncToken (#18487) * Increment version for textanalytics releases (#18665) Increment package version after release of Azure.AI.TextAnalytics * Fix description in csproj. (#18671) * Fix #16362 Add visual to the documentation to explain the mined opinions structure and naming better (#18525) Co-authored-by: NourEldin Yasser <noursalem95@gmail.com> * [textanalytics] fix AnalyzeOperationBatchWithStatisticsTest (#18516) Co-authored-by: NourEldin Yasser <noursalem95@gmail.com> * Sync eng/common directory with azure-sdk-tools for PR 1393 (#18666) * Update instructions to run the sample search query (#18654) * Update instructions to run the sample search query * Update AutoRest C# version (#18668) * Update assertion for ResourceGuid. * Fix #17811 Improve samples for Analyze (#18524) * [textanalytics] rename Sample_AnalyzeOperation.md to Sample_AnalyzeBatchActions.md * [textanalytics] Fix AnalyzeOperation Sample Source Code * [textanalytics] update code snippets in md files from samples source code * [textanalytics] remove polling samples and fix snippets references in readme.md and AnalyzeBatchActions.md Co-authored-by: NourEldin Yasser <noursalem95@gmail.com> * Update version of Azure.Search.Documents to 11.3.0-beta.1 (#18672) * mixed reality csharp sdk for 2021-01-01 API (#18448) * mixed reality charp sdk * update csproj * Add missing files * Update READMEs for Key Vault SDK betas (#18677) * Add session idle timeout option for session processor (#18640) * Add session idle timeout option for session processor * Fix docs * PR fb * Sync eng/common directory with azure-sdk-tools for PR 1303 (#18684) * Add PrepareRelease Script * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Change GeneralReleaseNotesParser logic * Change GeneralReleaseNotesParser.ps1 logic * Remoce GeneralReleaseNotesParsercopy * Update collect changelog and generalreleasenotes parser logic * Refine CollectChangelog Logic * Add logic for filtering collected changelog * Add Filter-ReleaseHighlights function * Update General ReleasNotes Logic * Delete GeneralReleaseNotesLogic.ps1 * Update Collect ChangeLogLogic Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Increment version for core releases (#18662) * Increment version for mixedreality releases (#18689) * Increment package version after release of Azure.MixedReality.Authentication * Increment package version after release of Azure.MixedReality.RemoteRendering * [synapse] Fix StartCreateSparkStatement API visibility (#18663) * Add import and non-sparse parameter functionality to job matrix generation (#18660) * [synapse] Fix AccessControl LIVE sample test (#18606) * [synapse] Changelog for Spark StartCreateSparkStatement release patch (#18693) * Sync eng/common directory with azure-sdk-tools for PR 1358 (#18686) * Extend Get-GitHubPullRequest to return only files * Add check to prevent eng/common changes that are not proper syncs * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update AutoRest C# version (#18674) * Enable passing devops pat for work item scripts (#18698) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Increment package version after release of Azure.Analytics.Synapse.Spark (#18709) * Change script parameters to boolean (#18708) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Add net5.0 to smoke tests. Fix dependency issues. (#18696) * Add net5.0 to smoke test target frameworks * Update azure.messaging.eventhubs to 5.3.0 in smoke tests * Remove daily version override for eventhubs in smoke test * Add check to catch delinquent eng/common changes (#18311) * Rename Microsoft.OpenTelemetry to Azure.Monitor.OpenTelemetry (#18702) * Revert "Add check to catch delinquent eng/common changes (#18311)" (#18710) This reverts commit 8ccc759. * Add variable setting warning level to warn (#18711) * [Communication] Remove administration package (#18655) * [Communication] Remove administration package * Remove the admin package from the ci.yml file * Update incorrect links in ReadMe files Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: matusthemostlygreat <77749405+matusthemostlygreat@users.noreply.github.com> Co-authored-by: Victor XField <vxfield@outlook.com> Co-authored-by: tg-msft <tg-msft@users.noreply.github.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Rahul Singh <53578268+rahuls-microsoft@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: praveenkuttappan <prmarott@microsoft.com> Co-authored-by: Larry Li <guli@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: Scott Schaab <sschaab@microsoft.com> Co-authored-by: Craig Treasure <Craig.K.Treasure@microsoft.com> Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: Shivangi Reja <shreja@microsoft.com> Co-authored-by: Yugang Wang <yugangw@microsoft.com> Co-authored-by: Alex Ghiondea <AlexGhiondea@users.noreply.github.com> Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: XField <58103249+vxfield@users.noreply.github.com> Co-authored-by: Paul Batum <paul.batum@gmail.com> Co-authored-by: kinelski <camaiaor@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Reza Jooyandeh <rejooyan@microsoft.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Suhas Mehta <suhas.mehta@microsoft.com> Co-authored-by: Matthew Burleigh <matt.burleigh@pobox.com> Co-authored-by: Azad Abbasi <azabbasi@microsoft.com> Co-authored-by: Robert Gao <robga@microsoft.com> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: nmaredia <75100936+nmaredia@users.noreply.github.com> Co-authored-by: Camilo Ramirez <camilo.ramirez@microsoft.com> Co-authored-by: Camilo Ramirez <juramir@microsoft.com> Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: PoAn (Baron) Chen <chen.baron@hotmail.com> Co-authored-by: Chenglong Liu <48578056+ChenglongLiu@users.noreply.github.com> Co-authored-by: Chenglong Liu <chengll@microsoft.com> Co-authored-by: David R. Williamson <drwill@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Dongwei Wang <bean0idear@163.com> Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> Co-authored-by: ajaygit158 <61898818+ajaygit158@users.noreply.github.com> Co-authored-by: Ajay Gupta <ajgupt@microsoft.com> Co-authored-by: Matt Ellis <matell@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Co-authored-by: Malcolm Tyrrell <36992510+MalcolmTyrrell@users.noreply.github.com> Co-authored-by: Anais Miller <anamille@microsoft.com> Co-authored-by: Yun Lu (MSFT) <53427149+Luyunmt@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Anjor S. Hemant <anjorsh@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Dominik <domessin@microsoft.com> Co-authored-by: Jon Gallant <2163001+jongio@users.noreply.github.com> Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> Co-authored-by: nichatur <69816349+nichatur@users.noreply.github.com> Co-authored-by: annoakes <45375852+annoakes@users.noreply.github.com> Co-authored-by: MahmoudYounes <a-mabadr@microsoft.com> Co-authored-by: Younes <v-mayounes@microsoft.com> Co-authored-by: NourEldin Yasser <65115481+a-noyass@users.noreply.github.com> Co-authored-by: NourEldin Yasser <noursalem95@gmail.com> Co-authored-by: roytan-microsoft <73565668+roytan-microsoft@users.noreply.github.com> Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Claimsproperty toTokenRequestContextto enable service clients to request additional claims when acquiring a token, as well as handle claims challenges from the service.