Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the package name for Doc.Ms readme #18262

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Normalize the package name for Doc.Ms readme #18262

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d08abf
Normalize the package name for Doc.Ms readme
sima-zhu Jan 28, 2021
7c27744
Merge branch 'master' into normalize_package_name
sima-zhu Jan 28, 2021
5e2b869
Put the regex in get-packageInfoFromPackageFile
sima-zhu Feb 1, 2021
e7a65cb
merge from upstream
sima-zhu Feb 1, 2021
bfd59ab
Update eng/scripts/Language-Settings.ps1
sima-zhu Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,9 @@ function GetExistingPackageVersions ($PackageName, $GroupId=$null)
LogError "Failed to retrieve package versions. `n$_"
return $null
}
}

# Turn the package name start with `Azure.Identity` to "Identity".
function Normalize-dotnet-Package-name ($PackageName) {
return $PackageName -replace "Azure." , ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ever be needed for Track 1 libraries? How about management? Seem it won't work for those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we will strip on Azure from the front of the track 2 management libraries as well.

Copy link
Contributor Author

@sima-zhu sima-zhu Feb 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep the one not start with Azure as it is for Doc.Ms readme file. So the change here does not apply to track 1 and management if it does not start with Azure.

}