-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BearerTokenChallengeAuthenticationPolicy #18368
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
397943b
BearerTokenAuthenticationPolicy in Experimental from scott's branch
christothes 21dd82d
wip
christothes 27aa443
Factor BearerTokenAuthPolicy
christothes 408c75d
remove unneeded types
christothes 3c2ed8c
TryGetTokenRequestContextFromChallenge
christothes f1973ad
wip
christothes 689a6b1
wip
christothes bccd190
tweaks to extensibility
christothes 2860d91
without OnBeforeRequest
christothes 1c8131a
name tuples
christothes 6a08628
eliminate the logic for checking empty scopes
christothes b5557a5
fix issue with comparing scopes
christothes 87846a7
small tweaks
christothes d1d90b9
merge with master TokenRequestContext
christothes af4a40f
set _scopes
christothes 17ee279
revert changes to experimental
christothes 609eb74
pr comments
christothes d999c68
replace RegEx with Span parsing
christothes fd14bef
remove RegEx fields
christothes 432b11d
small tweaks
christothes e353401
Merge remote-tracking branch 'upstream/master' into users/chriss/CAE
christothes 944dcb6
pr comments
christothes e634911
delete AzureCoreSharedEventSource
christothes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
sdk/core/Azure.Core/src/Shared/AzureCoreSharedEventSource.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System.Diagnostics.Tracing; | ||
|
||
namespace Azure.Core.Diagnostics | ||
{ | ||
[EventSource(Name = EventSourceName)] | ||
internal sealed class AzureCoreSharedEventSource : EventSource | ||
{ | ||
private const string EventSourceName = "Azure-Core-Shared"; | ||
|
||
private const int BackgroundRefreshFailedEvent = 19; | ||
|
||
private AzureCoreSharedEventSource() : base(EventSourceName, EventSourceSettings.Default, AzureEventSourceListener.TraitName, AzureEventSourceListener.TraitValue) { } | ||
|
||
public static AzureCoreSharedEventSource Singleton { get; } = new AzureCoreSharedEventSource(); | ||
|
||
[Event(BackgroundRefreshFailedEvent, Level = EventLevel.Informational, Message = "Background token refresh [{0}] failed with exception {1}")] | ||
public void BackgroundRefreshFailed(string requestId, string exception) | ||
{ | ||
WriteEvent(BackgroundRefreshFailedEvent, requestId, exception); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we actually need / care about a separate source for shared sources, though? Even though the sources are shared, do we feel it's not still part of "Core" as a concept? Or is this more of a case of not muddying the Core event waters?
/cc @pakrym
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I had this in experimental, so this may not be necessary anymore.