-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication] - PhoneNumbers - Update to GA swagger #18876
[Communication] - PhoneNumbers - Update to GA swagger #18876
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
sdk/communication/Azure.Communication.Common/tests/CommunicationRecordedTestSanitizer.cs
Outdated
Show resolved
Hide resolved
@@ -6,6 +6,7 @@ | |||
- Added PhoneNumberAdministrationClient (originally was part of the Azure.Communication.Administration package). | |||
- Added support to create PhoneNumberAdministrationClient with AzureKeyCredential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client is completely changed, please check with @minnieliu and make sure we align the changelogs
sdk/communication/Azure.Communication.PhoneNumbers/src/ClientDiagnostics.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/ClientDiagnostics.cs
Outdated
Show resolved
Hide resolved
...munication.PhoneNumbers/tests/PhoneNumberAdministrationClient/PhoneNumbersClientLiveTests.cs
Outdated
Show resolved
Hide resolved
...munication.PhoneNumbers/tests/PhoneNumberAdministrationClient/PhoneNumbersClientLiveTests.cs
Outdated
Show resolved
Hide resolved
735afd6
to
ac4f71e
Compare
387ca33
to
582426b
Compare
sdk/communication/Azure.Communication.PhoneNumbers/src/PhoneNumbersClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/PhoneNumbersClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/PhoneNumbersClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/Models/PhoneNumberSearchRequest.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/PhoneNumbersClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.PhoneNumbers/src/PhoneNumbersClient.cs
Outdated
Show resolved
Hide resolved
f37bb15
to
54787bc
Compare
54787bc
to
0de81a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment about the changelog. But let's do that in a separate PR
API review: https://apiview.dev/Assemblies/Review/b32afd45c457422992f506154f376d68
Swagger update PR: Azure/azure-rest-api-specs#12446
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.