Add support for Managed Instance for Apache Cassandra #19221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrossms
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
m-nash
requested changes
Mar 4, 2021
sdk/cosmosdb/Microsoft.Azure.Management.CosmosDB/src/Generated/CassandraResourcesOperations.cs
Show resolved
Hide resolved
Ran the command:
autorest C:\Users\frross\source\repos\azure-rest-api-specs\specification\cosmos-db\resource-manager\readme.md `
--csharp --version=v2 --reflect-api-versions `
--csharp-sdks-folder=C:\Users\frross\source\repos\azure-sdk-for-net\sdk `
--tags=package-2021-03-preview
The preview release has quite a different structure, so I went back to the last release from it (commit 18e1b96) and copied the test files here. The project builds, but the tests have a couple errors to fix.
The Swagger changes needed were checked in, so rerun autorun from the master branch in the main repo instead of against a local checkout so the metadata is correct.
|
@m-nash I'm getting test failures saying it can't find an ARM template from TestData that is supposed to be copied to the output directory. I got that pattern from other parts of the repo that do the same thing. Do you have any insight on why it's not working on Github's tests? |
I had hardcoded a \ instead of using Path.PathSeparator.
Instead of Path.Separator, which is making the build fail, just use a /, which is supported on all platforms.
m-nash
approved these changes
Mar 9, 2021
MehaKaushik
reviewed
Mar 17, 2021
| @@ -6,17 +6,14 @@ | |||
| <PropertyGroup> | |||
| <PackageId>Microsoft.Azure.Management.CosmosDB</PackageId> | |||
| <Description>Provides developers with libraries for the CosmosDB under Azure Resource manager to manage CosmosDB Account, Databases and child resources and their available management capabilities. Create, Delete, Update CosmosDB Account, Databases and child resources. Note: This client library is for CosmosDB under Azure Resource Manager.</Description> | |||
| <Version>2.0.0</Version> | |||
| <Version>2.1.0</Version> | |||
There was a problem hiding this comment.
this version is wrong. It should be 2.1.0-preview. I cannot release without this change.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Swagger PRs:
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.