Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test ReceiveLotOfMessagesWithoutSettling in Microsoft.Azure.ServiceBus #19454

Merged
merged 10 commits into from
Jun 10, 2021

Conversation

DorothySun216
Copy link
Contributor

@DorothySun216 DorothySun216 commented Mar 11, 2021

Fix a flaky test where we try to receive 5000+ messages in one batch. Removed the ignore tag so the test can be run with regular test suite.
Github Issue: #16265

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Service Bus label Mar 11, 2021
Copy link
Contributor Author

@DorothySun216 DorothySun216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/azp run net - servicebus - tests.data

Copy link
Contributor Author

@DorothySun216 DorothySun216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/azp run net - servicebus - tests.data

@jsquire
Copy link
Member

jsquire commented Mar 11, 2021

/azp run net - servicebus - tests.data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

Hi @DorothySun216. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Hi @DorothySun216. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@DorothySun216 DorothySun216 reopened this May 21, 2021
@DorothySun216
Copy link
Contributor Author

/azp run net - servicebus - tests.data

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label May 21, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DorothySun216
Copy link
Contributor Author

/azp run net - servicebus - tests.data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DorothySun216
Copy link
Contributor Author

/azp run net - servicebus - tests.data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DorothySun216
Copy link
Contributor Author

/azp run net - servicebus - tests.data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DorothySun216 DorothySun216 changed the title Failedtest Fix flaky test ReceiveLotOfMessagesWithoutSettling in Microsoft.Azure.ServiceBus May 28, 2021
@DorothySun216 DorothySun216 marked this pull request as ready for review May 28, 2021 23:24
Copy link
Member

@yvgopal yvgopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@DorothySun216
Copy link
Contributor Author

/azp run net - servicebus - tests.data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DorothySun216 DorothySun216 requested a review from yvgopal June 10, 2021 16:57
Copy link
Member

@yvgopal yvgopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DorothySun216 DorothySun216 merged commit 7f5485b into Azure:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Microsoft.Azure.ServiceBus] Test Failures: ReceiveLotOfMessagesWithoutSettling
4 participants