SDK code for shared gallery, image features and blob as source #19472

kangsun-ctrl · 2021-03-12T01:36:53Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

…ofile and shared gallery

…r-net into master

This reverts commit 051be54.

check-enforcer · 2021-03-12T01:44:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

* Creating nuget package for blob as source (Azure#20127) * save the auto-generation work * add gallery application version update auto-generation * nit, add new line * update record json * update record json and add new tests for caps gallery with sharing profile and shared gallery * save work for gallery with sharing profile, caps side test * update blob as source code * uncheck shared gallery test which can not run right now * save * save * add shared gallery tests * generate files again * Revert "generate files again" This reverts commit 051be54. * update gallery * revert unnecessary change * update examples * Update Microsoft.Azure.Management.Compute.csproj Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com>

…-sdk-for-net into master

grizzlytheodore · 2021-04-16T00:33:07Z

@allenjzhang pls merge. this adds new 2020-12-01 gallery.json to sdk

sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj

sdk/compute/Microsoft.Azure.Management.Compute/AzSdk.RP.props

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/GalleriesOperations.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/GalleriesOperationsExtensions.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IGalleriesOperations.cs

Sandido · 2021-04-19T19:46:34Z

sdk/compute/Microsoft.Azure.Management.Compute/tests/ScenarioTests/SharedGalleryTests.cs

+        // these needs to be decided and created, especially subscription.
+        // two gallery shared to the tenant, but only one gallery shared to the sub
+        protected const string GalleryUniqueName = "97f78232-382b-46a7-8a72-964d692c4f3f-LONGLIVEGALLERYFOJNVV";
+        protected const string GalleryImageName = "jmaesscc";


Are these resources that were created prior to running this test so the test could run?
If so, we HIGHLY advise to not do that. Have all the resource creation be automatic and in code, otherwise you will be responsible for their maintenance at all times.

This is long live resource that we also use for our bvt. So I think my team is responsible for their maintenance already. Also, I do not see any class initialization/cleanup decorator available. Without that, resource creation/cleanup is more troublesome.

Sandido · 2021-04-19T19:46:48Z

sdk/compute/Microsoft.Azure.Management.Compute/tests/ScenarioTests/SharedGalleryTests.cs

+        protected const string GalleryImageName = "jmaesscc";
+        protected const string GalleryImageVersionName = "1.0.0";
+
+        private string galleryAccessLocation = "eastus2euap";


Please use a non-Canary region for these tests.

same as above

sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/GalleriesOperations.cs

Sandido · 2021-04-21T18:35:38Z

...mpute/Microsoft.Azure.Management.Compute/src/Customizations/GalleriesOperationsExtensions.cs

+        /// <param name='galleryName'>
+        /// The name of the Shared Image Gallery.
+        /// </param>
+        public static async Task<Gallery> GetAsync(this IGalleriesOperations operations, string resourceGroupName, string galleryName)


The 'this' looks like incorrect syntax, remove it.

I think it is correct actually. VMSSOperationExtension has this too: https://github.com/kangsun-ctrl/azure-sdk-for-net/blob/master/sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/VirtualMachinesOperationsExtensions.cs

Sandido · 2021-04-21T18:37:19Z

...mpute/Microsoft.Azure.Management.Compute/src/Customizations/GalleriesOperationsExtensions.cs

+        /// <param name='cancellationToken'>
+        /// The cancellation token.
+        /// </param>
+        public static async Task<Gallery> GetAsync(this IGalleriesOperations operations, string resourceGroupName, string galleryName, CancellationToken cancellationToken = default(CancellationToken))


The 'this' looks like incorrect syntax, remove it.

same as above

Sandido

Just need to address the PR check failures before merging.

kangsun-ctrl · 2021-04-21T20:19:17Z

/azp

azure-pipelines · 2021-04-21T20:19:22Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Sandido · 2021-04-21T20:19:50Z

/azp run

azure-pipelines · 2021-04-21T20:19:55Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

grizzlytheodore · 2021-04-22T02:15:14Z

@allenjzhang please merge !

Sandido · 2021-04-22T20:23:30Z

@markcowl , @allenjzhang , looks good to me!

kangsun-ctrl added 17 commits October 10, 2020 17:43

save the auto-generation work

d57e4a2

add gallery application version update auto-generation

ab94c6d

nit, add new line

ecaa68e

update record json

565c469

update record json and add new tests for caps gallery with sharing pr…

dfce18d

…ofile and shared gallery

Merge branch 'master' of https://github.com/kangsun-ctrl/azure-sdk-fo…

41cff3c

…r-net into master

save work for gallery with sharing profile, caps side test

548eb77

update blob as source code

0e06c30

merge

84c8022

uncheck shared gallery test which can not run right now

d88f514

merge

eec14b5

save

2ea8208

save

e50747f

add shared gallery tests

70ad6ef

generate files again

051be54

Revert "generate files again"

891906e

This reverts commit 051be54.

update gallery

adf5678

ghost added the Compute label Mar 12, 2021

revert unnecessary change

c7ff79e

kangsun-ctrl mentioned this pull request Mar 12, 2021

Move shared gallery to stable folder, and update blob as source template Azure/azure-rest-api-specs#12442

Merged

25 tasks

kangsun-ctrl marked this pull request as ready for review March 16, 2021 18:01

kangsun-ctrl requested review from allenjzhang, bquantump, m-nash, markcowl, nisha-bhatia and YalinLi0312 as code owners March 16, 2021 18:01

openapi-assignment-bot bot assigned YalinLi0312 Mar 16, 2021

kangsun-ctrl marked this pull request as draft March 16, 2021 22:17

YalinLi0312 assigned allenjzhang Mar 25, 2021

kangsun-ctrl and others added 13 commits March 29, 2021 18:14

update examples

d069151

Merge branch 'cplat-gallery-build' into master

a45f4b5

Update AssemblyInfo.cs

5a4a269

update, include all generated files

3ea4d26

update

aa81408

Update Microsoft.Azure.Management.Compute.csproj

4feba73

nit

6586933

Update Microsoft.Azure.Management.Compute.csproj

4bb2445

Update AssemblyInfo.cs

e128572

Create AssemblyInfo.cs

37e507a

commit

883acac

Merge branch 'galleryImage-preview' of https://github.com/Azure/azure…

b48d52e

…-sdk-for-net into master

kangsun-ctrl marked this pull request as ready for review April 16, 2021 00:04

Sandido requested changes Apr 19, 2021

View reviewed changes

update, address comments

3160498

allenjzhang approved these changes Apr 20, 2021

View reviewed changes

Sandido requested changes Apr 20, 2021

View reviewed changes

sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/GalleriesOperations.cs Show resolved Hide resolved

update

1209e3f

Sandido requested changes Apr 21, 2021

View reviewed changes

Sandido approved these changes Apr 21, 2021

View reviewed changes

allenjzhang merged commit 652d1bd into Azure:master Apr 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK code for shared gallery, image features and blob as source #19472

SDK code for shared gallery, image features and blob as source #19472

kangsun-ctrl commented Mar 12, 2021 •

edited by grizzlytheodore

Loading

check-enforcer bot commented Mar 12, 2021

grizzlytheodore commented Apr 16, 2021

Sandido Apr 19, 2021

kangsun-ctrl Apr 19, 2021

Sandido Apr 19, 2021

kangsun-ctrl Apr 19, 2021

Sandido Apr 21, 2021

kangsun-ctrl Apr 21, 2021 •

edited

Loading

Sandido Apr 21, 2021

kangsun-ctrl Apr 21, 2021

Sandido left a comment

kangsun-ctrl commented Apr 21, 2021

azure-pipelines bot commented Apr 21, 2021

Sandido commented Apr 21, 2021

azure-pipelines bot commented Apr 21, 2021

grizzlytheodore commented Apr 22, 2021

Sandido commented Apr 22, 2021

SDK code for shared gallery, image features and blob as source #19472

SDK code for shared gallery, image features and blob as source #19472

Conversation

kangsun-ctrl commented Mar 12, 2021 • edited by grizzlytheodore Loading

All SDK Contribution checklist:

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

check-enforcer bot commented Mar 12, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

grizzlytheodore commented Apr 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kangsun-ctrl Apr 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sandido left a comment

Choose a reason for hiding this comment

kangsun-ctrl commented Apr 21, 2021

azure-pipelines bot commented Apr 21, 2021

Sandido commented Apr 21, 2021

azure-pipelines bot commented Apr 21, 2021

grizzlytheodore commented Apr 22, 2021

Sandido commented Apr 22, 2021

kangsun-ctrl commented Mar 12, 2021 •

edited by grizzlytheodore

Loading

kangsun-ctrl Apr 21, 2021 •

edited

Loading