Update AutoRest version to 47b422a4 #19959
Conversation
Add CustomEnityLookup skill and DocumentExtraction skill
Mohit-Chakraborty
requested review from
arv100kri,
bleroy,
brjohnstmsft,
heaths and
tg-msft
as code owners
ghost
added
the
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Show resolved
Hide resolved
| /// <summary> Changes the default fuzzy edit distance value for this entity. It can be used to change the default value of all aliases fuzzyEditDistance values. </summary> | ||
| public int? DefaultFuzzyEditDistance { get; set; } | ||
| /// <summary> An array of complex objects that can be used to specify alternative spellings or synonyms to the root entity name. </summary> | ||
| public IList<CustomEntityAlias> Aliases { get; set; } |
There was a problem hiding this comment.
I know we've talked about it, but we haven't made this change yet, have we? I.e. collection properties shouldn't be settable.
There was a problem hiding this comment.
Per internal discussion, these shouldn't be settable since they are collection properties. May be a bug in the generator. /cc @ShivangiReja @pakrym
There was a problem hiding this comment.
What should be the resolution?
An update to the generator followed by code regen?
There was a problem hiding this comment.
Pretty sure this property is nullable so we are forced to make it settable.
There was a problem hiding this comment.
In Search we already had that issue and resolved it without making them settable. Previously we used the NullAsEmpty attribute property (or something like that), but I don't remember where we landed finally off hand. Pretty sure it wasn't settable collection properties. @Mohit-Chakraborty , I recommend looking at existing models with collection properties and see what we're doing.
|
cc: @tg-msft |
|
Closing this PR as we are updating to a new spec. |
Most significant changes included here are from -