Fixing "sequence contains no elements" when querying storage #2015
Conversation
|
Can one of the admins verify this patch? |
|
Hi @jldgit, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
@azuresdkci test this please |
|
@asheniam Can you have someone on the insights team take a look at this PR contribution? |
|
@asheniam ping. |
|
Can one of the admins verify this patch? |
|
@azuresdkci add to whitelist |
| // Filter definitions by timegrain | ||
| var timegraindefinitions = from d in definitions | ||
| where d.MetricAvailabilities.Count > 0 | ||
| && d.MetricAvailabilities[0].TimeGrain == filter.TimeGrain |
There was a problem hiding this comment.
This will not work for metrics with multiple allowed timegrains, for which the query specifies one other than the first. It needs to be able to select the appropriate availability based on the requested timegrain.
|
@davmc, thanks for the review. @debugthings can you make the suggested changes? |
|
@debugthings Please respond to the review comments. Due to age, we will have to close this PR at the end of the week if there is no further response. |
|
Due to the age of the PR and checks failing for the PR, closing this PR |
|
Hi @debugthings, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
reopenfing at the request of the owner, who will be makign the suggested changes |
|
@debugthings I reopend this at your reuest, please update, or I will have to close this again. |
|
@debugthings Closing due to inactivity |
|
It's been forever but I wanted to close the loop on this. After really digging in with the customer we found that they were trying to pull two metric types that had incompatible time grains. They assumed the free space metric had the same granularity as data in/out. So when the application was run they just dumped all metrics into one query which generated the error above. In short, there is no need for a code change and there is no bug. |
…in (#39965) * Initial generated project (#1987) * Added admin live tests for classifiers (#2012) * Added admin live tests for models (#2015) * Misc operations + classify live tests (#2017) * Added admin live tests for misc operations * Added main live tests for classifiers * Generated from latest spec + added recordings (#39936) * Generated from the latest spec * Added recordings
When using this SDK to pull from either the classic or "new" storage model you cannot get any of the metrics via any combination of the filters. The exception thrown is "Sequence contains no matching element."
The fix is to remove the filtering operation out of the Group operation.
This screen shot is from Azure Powershell as it produces the quickest repro.
All existing tests for Insights.Test pass.