Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure.Storage.Blobs Sample issue #20254

Closed
wants to merge 3 commits into from

Conversation

Tianyun-G
Copy link
Contributor

Fix #19051

@jongio for notification.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Apr 9, 2021
@Tianyun-G Tianyun-G force-pushed the fix_new_issue branch 2 times, most recently from f2cf370 to b08eaaa Compare April 9, 2021 10:13
@Tianyun-G Tianyun-G closed this Apr 9, 2021
@Tianyun-G Tianyun-G reopened this Apr 9, 2021
@jsquire
Copy link
Member

jsquire commented Apr 9, 2021

@Tianyun-G: CI is failing because the generated code doesn't match the snippet changes. Would you be so kind as to run:

<< REPOSITORY ROOT>>/eng/scripts/Update-Snippets.ps1 -ServiceDirectory "storage"

@v-xuto
Copy link
Member

v-xuto commented May 14, 2021

@jsquire - We have updated by your comments, please re-review this PR.

@jsquire
Copy link
Member

jsquire commented May 18, 2021

@jsquire - We have updated by your comments, please re-review this PR.

I'm going to defer to the Storage team for review, as they own this library. My goal was just to assist with understanding the failing CI.

@check-enforcer
Copy link

check-enforcer bot commented Jul 6, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@amnguye
Copy link
Member

amnguye commented Jul 6, 2021

Apologies for not getting around to reviewing this PR. I actually noticed this problem when I was fixing some of the migration guide and resolved it with this PR that's already been merged.
#22380

I will go ahead and close this PR in preference to the one already merged. Please ping me if there are any other issues.

@amnguye amnguye closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure.Storage.Blobs Sample issue
4 participants