-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Azure.Storage.Blobs Sample issue #20254
Conversation
f2cf370
to
b08eaaa
Compare
@Tianyun-G: CI is failing because the generated code doesn't match the snippet changes. Would you be so kind as to run:
|
@jsquire - We have updated by your comments, please re-review this PR. |
I'm going to defer to the Storage team for review, as they own this library. My goal was just to assist with understanding the failing CI. |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
Apologies for not getting around to reviewing this PR. I actually noticed this problem when I was fixing some of the migration guide and resolved it with this PR that's already been merged. I will go ahead and close this PR in preference to the one already merged. Please ping me if there are any other issues. |
Fix #19051
@jongio for notification.