Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the suppression for namespace in mgmt sdks #21534

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Remove the suppression for namespace in mgmt sdks #21534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0a638b
remove no warn AZC0001
m-nash Jun 2, 2021
f50c368
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Jun 2, 2021
061b6f5
remove the namespace warn suppression from mgmt plane sdks
m-nash Jun 2, 2021
a5098d6
remove old todo
m-nash Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20210601.1" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210322.2" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210601.1" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
<PackageReference Update="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.20467.1" PrivateAssets="All" />
Expand Down
5 changes: 0 additions & 5 deletions eng/templates/Azure.ResourceManager.Template/src/Azure.ResourceManager.Template.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@
<Description>Azure Resource Manager client SDK for Azure resource provider ProviderFullName</Description>
<PackageTags>azure;management;arm;resource manager;ProviderNameLowercase</PackageTags>
</PropertyGroup>

<PropertyGroup>
<!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
<NoWarn>$(NoWarn);AZC0001</NoWarn>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion .../Azure.ResourceManager.AppConfiguration/src/Azure.ResourceManager.AppConfiguration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
</Description>
<PackageTags>azure;management;appconfiguration</PackageTags>
<NoWarn>$(NoWarn);AZC0001;AZC0008;</NoWarn>
<NoWarn>$(NoWarn);AZC0008;</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is still planning to be addressed in a future update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is just to get rid of 0001, the others will follow

<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
4 changes: 0 additions & 4 deletions ...cation/Azure.ResourceManager.Communication/src/Azure.ResourceManager.Communication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
For this release, see notes - https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/communication/Azure.ResourceManager.Communication/README.md and https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/communication/Azure.ResourceManager.Communication/CHANGELOG.md.
</Description>
<PackageTags>azure;management;communication</PackageTags>
<!--
AZC0001 - Azure.ResourceManager.Communication namespace needs to be registered in the analyzer
-->
<NoWarn>$(NoWarn);AZC0001</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<PropertyGroup>
<!-- TODO: Temp workaround. Should be fixed prior to release -->
<NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
<NoWarn>$(NoWarn);AZC0008</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<PropertyGroup>
<!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
<NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/dns/Azure.ResourceManager.Dns/src/Azure.ResourceManager.Dns.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</PropertyGroup>
<PropertyGroup>
<!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
<NoWarn>$(NoWarn);AZC0001;CS0618</NoWarn>
<NoWarn>$(NoWarn);CS0618</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/Azure.ResourceManager.EventHubs/src/Azure.ResourceManager.EventHubs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
</Description>
<PackageTags>azure;management;eventhub</PackageTags>
<NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
<NoWarn>$(NoWarn);AZC0008</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 0 additions & 2 deletions sdk/insights/Azure.ResourceManager.Insights/src/Azure.ResourceManager.Insights.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
</PropertyGroup>

<PropertyGroup>
<!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
<NoWarn>$(NoWarn);AZC0001</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/Azure.ResourceManager.KeyVault/src/Azure.ResourceManager.KeyVault.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</Description>
<PackageTags>azure;management;keyvault</PackageTags>
<!-- TODO: Temp workaround. Should be fixed prio release -->
<NoWarn>$(NoWarn);AZC0001;AZC0008;</NoWarn>
<NoWarn>$(NoWarn);AZC0008;</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
3 changes: 1 addition & 2 deletions ...eManager.MachineLearningServices/src/Azure.ResourceManager.MachineLearningServices.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@
</PropertyGroup>

<PropertyGroup>
<!-- TODO: Temp workaround to avoid error for preapproved namespace groups. Should be fixed prior to release -->
<!-- Link to preapproved, registered namespaces: https://azure.github.io/azure-sdk/registered_namespaces.html -->
<NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<PropertyGroup>
<!-- TODO: Temp workaround. Should be fixed prio release -->
<NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
<NoWarn>$(NoWarn);AZC0008</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion sdk/resourcemanager/Azure.ResourceManager.Core/src/Azure.ResourceManager.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
</Description>
<PackageTags>azure;management;resource</PackageTags>
<NoWarn>$(NoWarn);AZC0008;AZC0001;AZC0107;CA2214;CA1036;CA1067;CA1065;SA1028</NoWarn>
<NoWarn>$(NoWarn);AZC0008;AZC0107;CA2214;CA1036;CA1067;CA1065;SA1028</NoWarn>
<IncludeGeneratorSharedCode>true</IncludeGeneratorSharedCode>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/resources/Azure.ResourceManager.Resources/src/Azure.ResourceManager.Resources.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
</Description>
<PackageTags>azure;management;resource</PackageTags>
<NoWarn>$(NoWarn);AZC0008;AZC0001</NoWarn>
<NoWarn>$(NoWarn);AZC0008</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/sqlmanagement/Azure.ResourceManager.Sql/src/Azure.ResourceManager.Sql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<!-- TODO: As part of release process, this PropertyGroup can be removed once RP is approved for namespace -->
<NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/Azure.ResourceManager.Storage/src/Azure.ResourceManager.Storage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
This is a beta preview vesion. This version uses a next-generation code generator that introduces important breaking changes, but also new features (such as intuitive authentication, custom HTTP pipeline, distributed tracing and much more).
</Description>
<PackageTags>azure;management;storage</PackageTags>
<NoWarn>$(NoWarn);AZC0001;AZC0008</NoWarn>
<NoWarn>$(NoWarn);AZC0008</NoWarn>
<ExcludeMgmtCoreShared>true</ExcludeMgmtCoreShared>
</PropertyGroup>

Expand Down