-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure ReplyUri for AuthorizationCodeCredential #21597
Configure ReplyUri for AuthorizationCodeCredential #21597
Conversation
@christothes has this change already published to nuget? |
BTW @christothes, did you see this comment on your commit? |
Thanks for pointing this out - I missed this. It appears that this is indeed a bug. I'll look into this further. |
@christothes btw what is considered to be the auth code? Something like this:
or longer text we are getting when requesting auth code like this:
|
@christothes do you have in mind any estimates on when this could be published as some other beta package? I see you have created PR 24182 to fix that. I hope it will be included to 1.5.0-beta.5. Just curious when it is going to happen. |
It will be released next month |
@christothes I've tried to provide
Seems PR #24182 doesn't fix the issue. Did you try with real code, not just with unit test? |
|
What I actually did is added breakpoint in the code and set RedirectUri by hands during debug, then run the app next. Previously I had the error that redirect_uri is incorrect, now it's about code_verifier and code_challenge. |
Would you mind providing a simple repro scenario on this issue and continue the conversation there? #24183 |
It's a bit hard to reproduce. If I will be able to create separate repo, I'll add link there. |
fixes #21529