Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Added Authentication and CredentiaId properties to Data Feed Sources #21626

Merged
merged 14 commits into from
Jun 7, 2021
Merged

[MetricsAdvisor] Added Authentication and CredentiaId properties to Data Feed Sources #21626

merged 14 commits into from
Jun 7, 2021

Conversation

kinelski
Copy link
Member

@kinelski kinelski commented Jun 5, 2021

Fixes #18609.

@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Jun 5, 2021
@kinelski kinelski self-assigned this Jun 5, 2021
kinelski
kinelski commented Jun 5, 2021
View reviewed changes
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/DataFeed/DataFeed.cs
@@ -198,6 +198,8 @@ internal DataFeedDetail GetDataFeedDetail()
detail.Viewers.Add(viewer);
}

SetAuthenticationProperties(detail, DataSource);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have three models: a public one, an internal one used by the service, and another internal one (patch) used by the service during Update.

This method makes the transform public => service.

@kinelski kinelski marked this pull request as ready for review June 7, 2021 15:09
@kinelski kinelski requested review from maririos and removed request for tg-msft and KrzysztofCwalina June 7, 2021 15:09
@kinelski kinelski merged commit 755b7e2 into Azure:master Jun 7, 2021
@kinelski kinelski deleted the ma-sourcesAuth branch June 7, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

Assignees

@kinelski kinelski

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MetricsAdvisor] Credential Entity
2 participants
@kinelski @maririos