update docstrings for AnalyzeActions #21661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maririos
reviewed
Jun 7, 2021
There was a problem hiding this comment.
Also, looks like all the xxActionResult types need some docstring work for both the class and the properties.
For example: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/textanalytics/Azure.AI.TextAnalytics/src/ExtractKeyPhrasesActionResult.cs#L12
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsActions.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOptions.cs
Outdated
Show resolved
Hide resolved
|
Actually, nevermind about
I am making a change in those classes so I can update the docstrings |
added 2 commits
June 8, 2021 12:48
maririos
approved these changes
Jun 8, 2021
sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsResult.cs
Outdated
Show resolved
Hide resolved
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Dec 28, 2022
Adding new api-version 2022-12-01 to Microsoft.DataProtection (Azure#21661) * Base commit for updating Microsoft.DataProtection from version stable/2022-05-01 to version stable/2022-12-01 Base commit for updating Microsoft.DataProtection from version stable/2022-05-01 to version stable/2022-12-01 * Updating readme * Updating api version in new specs and examples * Updating examples * Adding CSR related changes * Adding softDeleteSettings to backupVault * Adding examples * fixing swagger * Fixing readme * Adding description * Adding immutability settings * Update dataprotection.json Added Expiry time field for RP contract * Update ListRecoveryPoints.json Updated ListRP example for expiry Time * Merging latest fix * Adding OperationalStore enum value * Using parameters from v4 common * Adding parameter for BackupInstanceName * PatchResourceGaurd Fix * Adding identity property in PatchResourceGuardInput * Removing identity in resourceGuard resource * Removing identity from ResourceGuard patch Co-authored-by: amchandn <43201777+amchandn@users.noreply.github.com> Co-authored-by: cvarsh <cvarsh@microsoft.com> Co-authored-by: Srinivas Charan Madu <smadu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #17807