[Storage] Perf test client ctors. #21671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kasobol-msft
requested review from
amishra-dev,
amnguye,
seanmcc-msft and
tg-msft
as code owners
amnguye
reviewed
Jun 7, 2021
|
|
||
| new DataLakeDirectoryClient(s_fileUri); | ||
| new DataLakeDirectoryClient(s_fileUri, s_tokenCredential); | ||
| new DataLakeDirectoryClient(s_fileUri, s_testEnvironment.DataLakeCredential); |
There was a problem hiding this comment.
Should there also be DataLakeFileClient and DataLakePathClient, or is this enough?
There was a problem hiding this comment.
good catch, this was supposed to be file client.
|
Do we also need to do queues? |
seanmcc-msft
approved these changes
Jun 7, 2021
mikeharder
approved these changes
Jun 7, 2021
There's no perf test project for Queues. @mikeharder is there a plan to have one? |
Ideally we should have at least one perf test for every SDK. It's primarily up to the SDK owner to create the perf test project. |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Dec 22, 2022
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (Azure#21671) * Fix s360 alerts for properties being returned in GET but not exising in PUT requests * Prettier fix * Fix model validation error for long running operation response missing location header * removed default value for array as it breaks the arm template schema creation * removed default value for array for managed hsm virtual network rule as it breaks the arm template schema creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #21622
Calls to various ctors and hierarchy are piled up in single test because: