Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version for translation releases #21700

Merged

Conversation

azure-sdk
Copy link
Collaborator

Increment package version after release of Azure.AI.Translation.Document

@ghost
Copy link

ghost commented Jun 8, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@check-enforcer
Copy link

check-enforcer bot commented Jun 8, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@maririos
Copy link
Member

maririos commented Jun 8, 2021

/check-enforcer override

@ghost ghost merged commit 583c3a9 into Azure:master Jun 8, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Dec 16, 2022
[Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2022-10-14-preview (Azure#21700)

* Adds base for updating Microsoft.DesktopVirtualization from version stable/2022-09-09 to version 2022-10-14-preview

* Updates readme

* Updates API version in new specs and examples

* Added removed changes from 2022-04-01-preview to 2022-10-14-preview

* Removed MigrationRequest from version

* Copied examples over from previous preview

* Added missing changes for private link to swagger

* Added enabled/disabled status to check descriptions.

* Added regex pattern to parameter in types.json

* reverted mistaken common type edit and added pattern to parameters

* Revert "Added enabled/disabled status to check descriptions."

This reverts commit ad177a4e36b3b42d6ac4eb37c622225de3bf95ec.

* Removed pattern requirement; will get exception on linter errors

* Revert "Revert "Added enabled/disabled status to check descriptions.""

This reverts commit 40ef1db774609e7440298a3d236c755aded86942.

* Replaced v1 and v2 common types with v3 and added 201 responses as directed from PR review.

* Only added v3 to new resources to avoid breaking changes

* Fixed incorrect find replace from param to def

* changed system data from v3 to v2 to avoid breaking changes

* Updated resource version from v3 to v1 to avoid breaking changes

* Removed added 201 responses

* Changed PrivateLinkResourceListResult to use internal definition and added pagination to PrivateLink collection calls

* Update to use same version of PrivateEndpointConnection type

* Update PrivateLink version from v3 to v2 to use the same Resource def

* Reverted PrivateLinkConnection v3 to v2 due to sdk problems.

* Added missed pagable to privatelink ListByHostpool
@azure-sdk azure-sdk deleted the increment-package-version-translation-935559 branch October 19, 2023 01:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants